<p></p>
<p><b>@eht16</b> requested changes on this pull request.</p>
<p dir="auto">Looks good. Had only a few remarks.</p><hr>
<p>In <a href="https://github.com/geany/geany/pull/1813#discussion_r878889313">src/sidebar.c</a>:</p>
<pre style='color:#555'>> @@ -1105,8 +1591,6 @@ void sidebar_init(void)
G_CALLBACK(sidebar_tabs_show_hide), NULL);
g_signal_connect_after(main_widgets.sidebar_notebook, "switch-page",
G_CALLBACK(on_sidebar_switch_page), NULL);
-
- sidebar_tabs_show_hide(GTK_NOTEBOOK(main_widgets.sidebar_notebook), NULL, 0, NULL);
</pre>
<p dir="auto">Removed because <code class="notranslate">sidebar_tabs_show_hide()</code> is called in <code class="notranslate">on_load_settings()</code> already?</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1813#discussion_r878890616">src/libmain.c</a>:</p>
<pre style='color:#555'>> @@ -1018,20 +1018,12 @@ static const gchar *get_locale(void)
GEANY_EXPORT_SYMBOL
-gint main_lib(gint argc, gchar **argv)
+void main_init_headless(void)
</pre>
<p dir="auto">While this sounds like a good idea, AFAIU this is completely unrelated in this PR?</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1813#discussion_r878890833">m4/geany-gtk.m4</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,33 @@
+dnl GEANY_CHECK_GTK
+dnl Checks whether the GTK stack is available and new enough. Sets GTK_CFLAGS and GTK_LIBS.
+AC_DEFUN([GEANY_CHECK_GTK],
</pre>
<p dir="auto">Great to move those checks into here.</p>
<p dir="auto">But pretty much unrelated to this PR, I think.<br>
Wouldn't it be better to do such refactorings on its own?</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1813#discussion_r878891226">src/keyfile.c</a>:</p>
<pre style='color:#555'>> @@ -187,7 +187,7 @@ static void init_pref_groups(void)
stash_group_add_toggle_button(group, &file_prefs.tab_close_switch_to_mru,
"tab_close_switch_to_mru", FALSE, "check_tab_close_switch_to_mru");
stash_group_add_integer(group, &interface_prefs.tab_pos_sidebar, "tab_pos_sidebar", GTK_POS_TOP);
- stash_group_add_integer(group, &interface_prefs.documents_show_paths, "documents_show_paths", SHOW_PATHS_LIST);
+ stash_group_add_integer(group, &interface_prefs.openfiles_path_mode, "openfiles_path_mode", -1);
</pre>
<p dir="auto">Since we rename the existing setting, users' Document List will be reset to the default.<br>
I think this is OK in this case as it is quickly changed again. Still, we could add an item to the <code class="notranslate">NEWS</code> file so it won't be forgotten and we can add it to the highlight items in the release announcement.</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1813#discussion_r878894565">src/utils.c</a>:</p>
<pre style='color:#555'>> @@ -468,7 +468,7 @@ gdouble utils_scale_round(gdouble val, gdouble factor)
/* like g_utf8_strdown() but if @str is not valid UTF8, convert it from locale first.
</pre>
<p dir="auto">Since <code class="notranslate">utf8_strdown()</code> is now public, it should be renamed to <code class="notranslate">utils_utf8_strdown()</code> or maybe better <code class="notranslate">utils_str_utf8_strdown()</code>.</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1813#discussion_r878894692">src/ui_utils.c</a>:</p>
<pre style='color:#555'>> @@ -68,7 +68,7 @@
"filetype: %f " \
"scope: %S")
-GeanyInterfacePrefs interface_prefs;
+GEANY_EXPORT_SYMBOL GeanyInterfacePrefs interface_prefs;
</pre>
<p dir="auto">Why is this necessary?</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1813#discussion_r878894819">src/sidebar.c</a>:</p>
<pre style='color:#555'>>
return cmp;
}
+GEANY_EXPORT_SYMBOL
</pre>
<p dir="auto">Why is this necessary?<br>
AFAIU <code class="notranslate">sidebar_create_store_openfiles()</code> could be even <code class="notranslate">static</code>.</p>
<hr>
<p>In <a href="https://github.com/geany/geany/pull/1813#discussion_r878894892">src/sidebar.c</a>:</p>
<pre style='color:#555'>> }
/* Also sets doc->priv->iter.
* This is called recursively in sidebar_openfiles_update_all(). */
+GEANY_EXPORT_SYMBOL
</pre>
<p dir="auto">Why is <code class="notranslate">GEANY_EXPORT_SYMBOL</code> necessary here?</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1813#pullrequestreview-980989213">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ434H5567EY372SSITVLJNPFANCNFSM4EWIWKTQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJ7XRMA5OA342Z7F44DVLJNPFA5CNFSM4EWIWKT2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOHJ4LKHI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/1813/review/980989213</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/1813#pullrequestreview-980989213",
"url": "https://github.com/geany/geany/pull/1813#pullrequestreview-980989213",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>