<p></p>
<p><b>@techee</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/3204#discussion_r873171340">src/tagmanager/tm_workspace.c</a>:</p>
<pre style='color:#555'>> @@ -453,19 +419,19 @@ static GList *lookup_includes(const gchar **includes, gint includes_count)
 #ifdef HAVE_GLOB_H
        globbuf.gl_offs = 0;
 
-       if (includes[0][0] == '"') /* leading \" char for glob matching */
+       if (sources[0][0] == '"')  /* leading \" char for glob matching */
</pre>
<blockquote>
<p dir="auto">I know its not something you changed (except the variable name) but where did this " come from? Its not mentioned in the manual as being required for globbing, nor in the parameter description of sources?</p>
</blockquote>
<p dir="auto">This seems to be wrong. I think this was meant to detect</p>
<pre class="notranslate"><code class="notranslate">geany -g *
</code></pre>
<p dir="auto">vs</p>
<pre class="notranslate"><code class="notranslate">geany -g "*"
</code></pre>
<p dir="auto">where in the first case the shell expands <code class="notranslate">*</code> to the list of files Geany receives as its argument list while in the second case it receives <code class="notranslate">*</code> (but without the <code class="notranslate">"</code> which gets removed by the shell).</p>
<p dir="auto">Not sure what we want and whether we actually want/need to support globbing by ourselves or whether what the shell does for us is sufficient already. I think the situation where this might be useful is when there are too many files matching the patterns so they exceed the max. number of command-line arguments.</p>
<p dir="auto">Maybe we could just drop this check completely and always try to apply globbing (when <code class="notranslate">HAVE_GLOB_H</code> is defined).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/3204#discussion_r873171340">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ4BDRZF5ERVHZ4JTKTVKD5ATANCNFSM5V4BUHKQ">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJ4Q5JLTYM2UHNVYKYDVKD5ATA5CNFSM5V4BUHK2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOHIAXX5Y.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/3204/review/973175799</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/3204#discussion_r873171340",
"url": "https://github.com/geany/geany/pull/3204#discussion_r873171340",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>