<p></p>
<p><b>@kugel-</b> requested changes on this pull request.</p>

<p dir="auto">Minor stuff.</p>
<p dir="auto">The "walk class hierarchy up for scope completion" makes a tiny bit nervous but it's your call. It would have been better to also separate this out but I don't want you to kill me now so keep it :-)</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/3185#discussion_r867397212">src/symbols.c</a>:</p>
<pre style='color:#555'>>      foreach_ptr_array(tmtag, i, tags)
        {
+               if (!tm_workspace_is_autocomplete_tag(tmtag, doc->tm_file, current_line, current_scope))
</pre>
<p dir="auto">Can you add a comment why this condition is needed now?  It's not entirely clear to me in the context of "goto tag"</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/3185#discussion_r867399691">src/tagmanager/tm_workspace.c</a>:</p>
<pre style='color:#555'>>  {
-       TMTag **tag, *last = NULL;
-       guint i, count, num;
+       TMParserType lang = current_file ? current_file->lang : TM_PARSER_NONE;
+
+       /* ignore local variables from other files/functions or after current line */
+       gboolean valid = !(tag->type & tm_tag_local_var_t) ||
+               (current_file == tag->file &&
+                current_line >= tag->line &&
</pre>
<p dir="auto">Out of curiosity, why did you drop the idea of making this language specific? I think <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/elextr/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/elextr">@elextr</a> had a good example why this might not work so well for python.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/3185#pullrequestreview-965365260">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ5RATPGXYMIXO4BUWDVI3S5BANCNFSM5UWGU33A">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJ2OBOEIKT65TYLL3LTVI3S5BA5CNFSM5UWGU33KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOHGFE4DA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/3185/review/965365260</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/3185#pullrequestreview-965365260",
"url": "https://github.com/geany/geany/pull/3185#pullrequestreview-965365260",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>