<p></p>
<p dir="auto"><a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/kugel-/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kugel-">@kugel-</a> I'd also like to discuss the stuff from here:</p>
<p dir="auto"><a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1220960734" data-permission-text="Title is private" data-url="https://github.com/geany/geany/issues/3185" data-hovercard-type="pull_request" data-hovercard-url="/geany/geany/pull/3185/hovercard?comment_id=958518326&comment_type=review" href="https://github.com/geany/geany/pull/3185#pullrequestreview-958518326">#3185 (review)</a></p>
<p dir="auto">I just don't know whether it means you are against the patch completely or whether it would get approved by you under some conditions. Some things are unfixable by nature - it will be a C/C++ only thing and it will make some assumptions. Potential performance problems are fixable as I hinted in my previous posts. As <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/users/elextr/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/elextr">@elextr</a> said, it's a heuristic only to improve sorting so it doesn't have to be perfect and the results seem better with it than without it.</p>
<p dir="auto">I'd also like to know your opinion on how it should be implemented so I don't spend time preparing a PR that doesn't get approved.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/3185#issuecomment-1118479723">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ6JTIXXE2YKJMQNSK3VIO35PANCNFSM5UWGU33A">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJ3TNWVTHNLD3Y74TJDVIO35PA5CNFSM5UWGU33KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIKVKK2Y.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/3185/c1118479723</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/3185#issuecomment-1118479723",
"url": "https://github.com/geany/geany/pull/3185#issuecomment-1118479723",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>