<p></p>
<p><b>@kugel-</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/3185#discussion_r862519422">src/tagmanager/tm_workspace.c</a>:</p>
<pre style='color:#555'>> +            !(tag->type & tm_tag_local_var_t) &&
+               is_autocomplete_tag(tag, info);
+}
+
+
+static guint copy_tags(GPtrArray *dst, TMTag **src, guint src_len, GHashTable *name_table,
+       gint num, gboolean (*predicate) (TMTag *, CopyInfo *), CopyInfo *info)
+{
+       guint i;
+
+       g_return_val_if_fail(src && dst, 0);
+
+       for (i = 0; i < src_len && num > 0; i++)
+       {
+               TMTag *tag = *src;
+               if (predicate(tag, info) &&
</pre>
<p dir="auto">Regardless of the order, IMO the call to <code class="notranslate">is_autocomplete_tag()</code> doesn't need to be duplicated in each predicate function but can be called in one place here, especially if the compiler whats to inline it.</p>
<p dir="auto">Indirect calls aren't as free as direct calls but it lets not focus on that, I don't care much.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/3185#discussion_r862519422">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ3LNNPIQKR2JJ6SOBDVH3UFZANCNFSM5UWGU33A">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJZCWLTUTRHM5GXAEBTVH3UFZA5CNFSM5UWGU33KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOHERYG7Y.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/3185/review/958628735</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/3185#discussion_r862519422",
"url": "https://github.com/geany/geany/pull/3185#discussion_r862519422",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>