<p dir="auto">I tested Geany with valgrind to make sure <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1220960734" data-permission-text="Title is private" data-url="https://github.com/geany/geany/issues/3185" data-hovercard-type="pull_request" data-hovercard-url="/geany/geany/pull/3185/hovercard" href="https://github.com/geany/geany/pull/3185">#3185</a> didn't introduce any memory leaks (it seems it didn't) and noticed this leak in the docbook parser (which we maintain by ourselves so no upstream patch needed). I'll merge this in a few days unless there are objections.</p>
<p dir="auto">There are also leaks in Fortran (fixed upstream) and VHDL (different parser upstream) parsers which will get fixed once we merge the upstream versions.</p>
<p dir="auto">For (my) future reference, I used valgrind with these parameters:</p>
<div class="snippet-clipboard-content position-relative overflow-auto" data-snippet-clipboard-copy-content="G_SLICE=always-malloc G_DEBUG=gc-friendly:resident-modules ./libtool --mode=execute valgrind --tool=memcheck --leak-check=full --leak-resolution=high --log-file=vgdump --suppressions=/usr/share/glib-2.0/valgrind/glib.supp src/geany"><pre class="notranslate"><code class="notranslate">G_SLICE=always-malloc G_DEBUG=gc-friendly:resident-modules ./libtool --mode=execute valgrind --tool=memcheck --leak-check=full --leak-resolution=high --log-file=vgdump --suppressions=/usr/share/glib-2.0/valgrind/glib.supp src/geany
</code></pre></div>

<hr>

<h4>You can view, comment on, or merge this pull request online at:</h4>
<p>  <a href='https://github.com/geany/geany/pull/3187'>https://github.com/geany/geany/pull/3187</a></p>

<h4>Commit Summary</h4>
<ul>
  <li><a href="https://github.com/geany/geany/pull/3187/commits/278177450081a1a7665ae79849708736de519d63" class="commit-link">2781774</a>  Fix docbook parser memory leak</li>
</ul>

<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/geany/geany/pull/3187/files">1 file</a>)</p>
<ul>
  <li>
    <strong>M</strong>
    <a href="https://github.com/geany/geany/pull/3187/files#diff-afa2a65b238b6c879670ecd5f5ce09d578023e7d1ec5c320547189f2099d7381">ctags/parsers/geany_docbook.c</a>
    (2)
  </li>
</ul>

<h4>Patch Links:</h4>
<ul>
  <li><a href='https://github.com/geany/geany/pull/3187.patch'>https://github.com/geany/geany/pull/3187.patch</a></li>
  <li><a href='https://github.com/geany/geany/pull/3187.diff'>https://github.com/geany/geany/pull/3187.diff</a></li>
</ul>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/3187">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJZ2GYUKGDKPIJZ66QDVHU6XDANCNFSM5UYNNJIA">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJYUN3K5J2ZNBNLXV2DVHU6XDA5CNFSM5UYNNJIKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4SGT23OA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/3187</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/3187",
"url": "https://github.com/geany/geany/pull/3187",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>