<p></p>
<p dir="auto">As we all know I'm not <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/b4n/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/b4n">@b4n</a> and I'm sure nobody is as good as he is in reviewing such things but anyway I gave this PR a test and review and it looks very good!!</p>
<p dir="auto">Oh, and please don't take this as an application for becoming the next tagmanager expert :D.</p>
<p dir="auto">Thank you so much <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/techee/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/techee">@techee</a> for this hard work. Much appreciated.</p>
<p dir="auto">I got a few rather harmless compiler warnings:</p>
<pre><code>tm_parser.c: In function ‘tm_parser_get_sidebar_info’:
tm_parser.c:1087:19: warning: comparison of integer expressions of different signedness: ‘gint’ {aka ‘int’} and ‘guint’ {aka ‘unsigned int’} [-Wsign-compare]
 1087 |         if (group >= map->group_num)
      |                   ^~
tm_parser.c:1081:15: warning: unused variable ‘i’ [-Wunused-variable]
 1081 |         guint i;
      |               ^
</code></pre>
<p dir="auto">Easy enough I guess.</p>
<pre><code>At top level:
tm_parser.c:74:25: warning: ‘map_C_old_parser’ defined but not used [-Wunused-variable]
   74 | static TMParserMapEntry map_C_old_parser[] = {
      |                         ^~~~~~~~~~~~~~~~
</code></pre>
<p dir="auto"><code>map_C_old_parser</code> is used for Ferite and GLSL according to its comment. Ferite is gone and GLSL used the normal C parser, so I guess this whole map entry can be removed?</p>
<p dir="auto">Apart from that, I'd suggest to merge this soon to get more real life testing (I use master for daily work).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/3137#issuecomment-1086885302">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ4K2WGMFK42G263XODVDGWG5ANCNFSM5RI7FD3Q">unsubscribe</a>.<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJ6OZ55CYO6MEK3HJT3VDGWG5A5CNFSM5RI7FD32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOIDEI3NQ.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/3137/c1086885302</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/3137#issuecomment-1086885302",
"url": "https://github.com/geany/geany/pull/3137#issuecomment-1086885302",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>