<p></p>
<blockquote>
<p dir="auto"><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/techee/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/techee">@techee</a> Can you please have a specific look at <a href="https://github.com/geany/geany/pull/2761/commits/33ac301fe9ec732aff7ecaa4b0d332edc70e45e4">33ac301</a> ? Is it OK to do it this way? My understanding of the comment is that the actual values of the defines is irrelevant.</p>
</blockquote>
<p dir="auto">I think so, yeah. I believe whatever compiles and makes unit tests pass is OK (I haven't tried yet though). Also the comment in configure.ac may be invalid now because something has changed in uctags in the meantime and these macros don't need to be defined any more.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2761#issuecomment-1065210092">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ4MW4I3ZOVER6YOW2TU7NP7HANCNFSM4ZDZAFLA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJ3N366TN5YMHONH6X3U7NP7HA5CNFSM4ZDZAFLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOH565B3A.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/2761/c1065210092</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2761#issuecomment-1065210092",
"url": "https://github.com/geany/geany/pull/2761#issuecomment-1065210092",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>