<p></p>
<p dir="auto">It looks pretty good now!<br>
Here my full build log: <a href="https://gist.github.com/eht16/b38c656d6f2edab62832f181248108c1">https://gist.github.com/eht16/b38c656d6f2edab62832f181248108c1</a></p>
<p dir="auto">Findings:</p>
<ul dir="auto">
<li>there is a deprecation notice in <a href="https://gist.github.com/eht16/b38c656d6f2edab62832f181248108c1#file-gistfile1-txt-L73">https://gist.github.com/eht16/b38c656d6f2edab62832f181248108c1#file-gistfile1-txt-L73</a> but I guess we could keep it for now</li>
<li>Plugins failed to compile first because meson installs geany.pc and the rest of the libs in <code>$prefix/lib/x86_64-linux-gnu</code>. I'm not sure if this is OK or not, at least it is different from autotools. With <code>./configure --prefix=/tmp/install-meson --with-geany-libdir=/tmp/install-meson/lib/x86_64-linux-gnu</code> Plugins compiled fine.</li>
<li>some files are not or in different locations installed compared to autotools. I added a list of differences in installed files in <a href="https://gist.github.com/eht16/b38c656d6f2edab62832f181248108c1#file-differences-in-installed-files-between-autotools-and-meson">https://gist.github.com/eht16/b38c656d6f2edab62832f181248108c1#file-differences-in-installed-files-between-autotools-and-meson</a>.</li>
<li>I did <em>not</em> test on Windows, we can do this post-merge</li>
</ul>
<p dir="auto">I'd say we should sort out the install differences but then good to merge.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2761#issuecomment-1038303176">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ67AD6YTR76ZCH3XD3U27WWJANCNFSM4ZDZAFLA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJ2KD4KIF4PXQEUQPUTU27WWJA5CNFSM4ZDZAFLKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHXRT7SA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/2761/c1038303176</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2761#issuecomment-1038303176",
"url": "https://github.com/geany/geany/pull/2761#issuecomment-1038303176",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>