<p></p>
<blockquote>
<p dir="auto"><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/techee/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/techee">@techee</a> I don't disagree with most of what you said above, except that an unstable Geany means anybody who tests has to not use it as their production tool, and well, that means it won't get much more testing than individual PRs will. Its a damned if we do, damned if we don't situation, sigh.</p>
</blockquote>
<p dir="auto">True. But with the parser pull requests at least there's pretty much no Geany code affected apart from the mappings and the parsers themselves should be reasonably well tested upstream (the unit tests use fuzzing and valgrind). And we'll run into this in the future releases too - we'll just copy the upstream version of all parsers and I think none of us will have enough time to manually test every single filetype for various input. So for the parsers we'll have to more or less trust the quality of the upstream code.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/3012#issuecomment-1013731412">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ4BFA773QAYAXIXFH3UWG4IPANCNFSM5IOB6Z2A">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJ3MAXIASORYXTJE45DUWG4IPA5CNFSM5IOB6Z2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHRWFAVA.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/3012/c1013731412</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/3012#issuecomment-1013731412",
"url": "https://github.com/geany/geany/pull/3012#issuecomment-1013731412",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>