<p></p>
<p><b>@eht16</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/3055#discussion_r777200580">src/callbacks.c</a>:</p>
<pre style='color:#555'>>              sidebar_select_openfiles_item(doc);
                ui_save_buttons_toggle(doc->changed);
                ui_set_window_title(doc);
                ui_update_statusbar(doc, -1);
                ui_update_popup_reundo_items(doc);
                ui_document_show_hide(doc); /* update the document menu */
                build_menu_update(doc);
-               sidebar_update_tag_list(doc, FALSE);
+               if (g_strcmp0(entry_text, doc->priv->tag_filter) != 0)
+                       gtk_entry_set_text(filter_entry, doc->priv->tag_filter);
</pre>
<p dir="auto">If the text of the filter entry is changed because it differs from the document's filter, <code>gtk_entry_set_text()</code> will eventually emit the "changed" signal and in its handler <code>sidebar_update_tag_list()</code> is called and then below it is called again.<br>
So if the new or previous document have filters set and they don't equal, we update the symbol list twice on each notebook page change.</p>
<p dir="auto">Maybe we could just make the symbol list update below dependent of the if condition above?</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/3055#discussion_r777200876">src/symbols.c</a>:</p>
<pre style='color:#555'>>  
        g_return_val_if_fail(doc, NULL);
 
        if (! doc->tm_file || ! doc->tm_file->tags_array)
                return NULL;
 
+       tf_strv = g_strsplit_set(doc->priv->tag_filter, " ", -1);
</pre>
<p dir="auto">This means we can have multiple filters seperarted by space which are then combined (AND)?<br>
At least it feels so while testing. This is cool but might not be too obvious to the user. Maybe document this in the widget's tooltip?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/3055#pullrequestreview-842405701">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ7MMFKLYIVQ3QLPE2TUUBX27ANCNFSM5J6JZAIQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<br />You are receiving this because you are subscribed to this thread.<img src="https://github.com/notifications/beacon/AAIOWJ5KPXG2KVESPXLOOOLUUBX27A5CNFSM5J6JZAI2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGI3BORI.gif" height="1" width="1" alt="" /><span style="color: transparent; font-size: 0; display: none; visibility: hidden; overflow: hidden; opacity: 0; width: 0; height: 0; max-width: 0; max-height: 0; mso-hide: all">Message ID: <span><geany/geany/pull/3055/review/842405701</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/3055#pullrequestreview-842405701",
"url": "https://github.com/geany/geany/pull/3055#pullrequestreview-842405701",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>