<p></p>
<p dir="auto">s/I created <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1060634652" data-permission-text="Title is private" data-url="https://github.com/geany/geany/issues/3015" data-hovercard-type="issue" data-hovercard-url="/geany/geany/issues/3015/hovercard" href="https://github.com/geany/geany/issues/3015">#3015</a> to/I created <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1075821716" data-permission-text="Title is private" data-url="https://github.com/geany/geany/issues/3050" data-hovercard-type="pull_request" data-hovercard-url="/geany/geany/pull/3050/hovercard" href="https://github.com/geany/geany/pull/3050">#3050</a> to/  :)</p>
<p dir="auto">To the topic:</p>
<ul dir="auto">
<li>looks quite good!</li>
<li>I gave it a quick try and works as advertised.</li>
<li>I agree on better searching case-insensitive.</li>
<li>maybe the update of the symbol list on each notebook tab change might be a noticeable performance hit on older machines ("unfortunately" I've recently got a new notebook with a bleeding fast CPU so I won't notice :D).</li>
</ul>
<p dir="auto">I see why the update on notebook tab change is necessary; the symbol filter text is static and applies to all documents. I think it would be even better to have filters per document, otherwise it could be confusing if I switch to another document and suddenly the symbol list is empty. After wondering about it, the user will probably realize it's because of the still set filter and then will clear the filter.<br>
Though having per document filters obviously requires much more efforts :(.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2657#issuecomment-990278175">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ6WQH4IQM4MAQRB7J3UQENM3ANCNFSM4TVARZXQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJ5LRIMD6YYLQDA4RZTUQENM3A5CNFSM4TVARZX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHMDHEHY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2657#issuecomment-990278175",
"url": "https://github.com/geany/geany/pull/2657#issuecomment-990278175",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>