<p></p>
<p><b>@eli-schwartz</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2761#discussion_r764412600">meson.build</a>:</p>
<pre style='color:#555'>> +    ['memcpy',  '#include <string.h>'],
+    ['mkstemp', '#include <stdlib.h>'],
+    ['regcomp', '#include <regex.h>'],
+    ['socket', '#include <sys/socket.h>'],
+    ['strerror', '#include <string.h>'],
+    ['strstr', '#include <string.h>'],
+    ['wcrtomb', '#include <wchar.h>'],
+    ['wcscoll', '#include <wchar.h>'],
+]
+
+foreach h : check_headers
+    define = 'HAVE_' + h.underscorify().to_upper()
+    if cc.has_header(h)
+               cdata.set(define, 1)
+       else
+               cdata.set(define, false)
</pre>
<p dir="auto">Several times you do <code>cdata.get()</code> on values that could be either int <code>1</code> or bool <code>false</code>, and that evaluates to a meson syntax error when trying to check the "truthiness" of an integer. It doesn't build by default for me.</p>
<p dir="auto">Which systems was this tested on? Seems like a system that has none of: glibc, fnmatch, regcomp (all 3 need to evaluate to false for configuration to pass).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2761#pullrequestreview-825838658">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ75B73XXFA4ZMQCVGDUP2DZRANCNFSM4ZDZAFLA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJ74O3L5RZSHQU2WSELUP2DZRA5CNFSM4ZDZAFLKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGE4UYQQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2761#pullrequestreview-825838658",
"url": "https://github.com/geany/geany/pull/2761#pullrequestreview-825838658",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>