<p></p>
<blockquote>
<blockquote>
<p dir="auto">Ok. Let's go this way. I'll try to prepare PRs for uctags with the two missing features. If/When they are merged, we can sync the Pascal parser.</p>
</blockquote>
<p dir="auto">Cool, I was going to prepare the PR myself - you were too fast :-)</p>
</blockquote>
<p dir="auto">:)</p>
<p dir="auto">However, I only PR'ed the argument list parsing feature.<br>
While preparing tests for the "type" parsing, I noticed the current code is quite buggy and incomplete. It only parses very easy type declarations but it probably fails for real world uses.<br>
For example:</p>
<div class="highlight highlight-source-pascal"><pre><span class="pl-k">type</span>
  TTest=<span class="pl-k">class</span>
    <span class="pl-k">procedure</span> <span class="pl-en">Test1</span>;
    <span class="pl-k">procedure</span>  <span class="pl-en">Test2</span>;
    <span class="pl-k">procedure</span>   <span class="pl-en">Test3</span>;
  <span class="pl-k">end</span>;</pre></div>
<p dir="auto">Will create a tag for "TTest" but also for the procedures "Test2" and "Test3" which are wrong. And "Test1" is missing for some reason (fun fact: even our test case expects that broken behavior in <a href="https://github.com/geany/geany/blob/master/tests/ctags/bug612019.pas.tags">https://github.com/geany/geany/blob/master/tests/ctags/bug612019.pas.tags</a>).</p>
<p dir="auto">I guess the parsing of "type" declarations needs to implemented in a more sophisticated way. At least I don't want to submit it upstream in the current state.<br>
Since I don't want and can't fix the implementation, we maybe should just remove that particular feature instead of keeping an incomplete implementation.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2991#issuecomment-981696157">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJZHLPX6SM6JVDKDDPDUOOGEJANCNFSM5HTSAKMA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJ2FDO6HFVOJIAYQ333UOOGEJA5CNFSM5HTSAKMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHKBX5HI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2991#issuecomment-981696157",
"url": "https://github.com/geany/geany/pull/2991#issuecomment-981696157",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>