<p></p>
<p dir="auto">I had a quick look on the changes and this looks good, we'll get some more new tag types and probably the newer uctags code is less buggy than the current ones.</p>
<p dir="auto">Though at least in the Pascal parser we will lose two features:</p>
<ul dir="auto">
<li>parsing "type" definitions (IIRC "type" in Pascal is somewhat similar to "structs" in C)</li>
<li>parsing argument list of functions</li>
</ul>
<p dir="auto">This two features are not in the uctags Pascal parser. I don't know where they came from, maybe we added them ourselves in the past.</p>
<p dir="auto">Since these could be useful for others as well, it might be best to push these two upstream to uctags, so we'll get them back with the next uctags update.</p>
<p dir="auto">Until then, it might be ok to have the two features removed (which will also solve <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1046472413" data-permission-text="Title is private" data-url="https://github.com/geany/geany/issues/2987" data-hovercard-type="pull_request" data-hovercard-url="/geany/geany/pull/2987/hovercard" href="https://github.com/geany/geany/pull/2987">#2987</a>) by this PR and get them back with the next uctags sync.</p>
<p dir="auto">An alternative could be to remove the Pascal parser from this PR and merge <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="1046472413" data-permission-text="Title is private" data-url="https://github.com/geany/geany/issues/2987" data-hovercard-type="pull_request" data-hovercard-url="/geany/geany/pull/2987/hovercard" href="https://github.com/geany/geany/pull/2987">#2987</a> in the meantime.</p>
<p dir="auto">I prefer the first option: use the uctags Pascal parser with this PR.</p>
<p dir="auto">What do you think?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2991#issuecomment-981063263">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJYQE6R2GLHUR6SI32LUOICXLANCNFSM5HTSAKMA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJ6AWOOUDF36RE2W7T3UOICXLA5CNFSM5HTSAKMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHJ45MXY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2991#issuecomment-981063263",
"url": "https://github.com/geany/geany/pull/2991#issuecomment-981063263",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>