<p dir="auto">This pull request updates the python parser to the uctags version. The most interesting things are from the following commit messages from the pull request:</p>
<p dir="auto">tm_ctags update:</p>
<div class="snippet-clipboard-content position-relative overflow-auto" data-snippet-clipboard-copy-content="The new parser generates 2 tags for import statements like
from A import B
For A tag of the 'i' kind is generated, for B, tag of the kind 'x' is
generated. B includes A in its scope and when we omit generation of
'i', imports are printed in the sidebar with the full scope information
like
Imports
django.views.decorators.csrf.csrf_exempt
django.views.decorators.csrf.csrf_exempt2
django.views.decorators.http.require_POST
When we generate 'i' and map it to something (I used tm_tag_externvar_t
like for the imports themselves, there's nothing in the tag types
we have that would be a good semantic candidate here), the result
in the sidebar is
Imports
django.views.decorators.csrf
csrf_exempt
csrf_exempt2
django.views.decorators.http
require_POST
which is more readable IMO.
"><pre><code>The new parser generates 2 tags for import statements like
from A import B
For A tag of the 'i' kind is generated, for B, tag of the kind 'x' is
generated. B includes A in its scope and when we omit generation of
'i', imports are printed in the sidebar with the full scope information
like
Imports
django.views.decorators.csrf.csrf_exempt
django.views.decorators.csrf.csrf_exempt2
django.views.decorators.http.require_POST
When we generate 'i' and map it to something (I used tm_tag_externvar_t
like for the imports themselves, there's nothing in the tag types
we have that would be a good semantic candidate here), the result
in the sidebar is
Imports
django.views.decorators.csrf
csrf_exempt
csrf_exempt2
django.views.decorators.http
require_POST
which is more readable IMO.
</code></pre></div>
<p dir="auto">cython unit test updates:</p>
<div class="snippet-clipboard-content position-relative overflow-auto" data-snippet-clipboard-copy-content="I'm not sure if cython is officially supported by uctags and there's a
slight problem where the new parser omits space between type and
function argument name. E.g. it produces
method(self,inti)
instead of
method(self,int i)
"><pre><code>I'm not sure if cython is officially supported by uctags and there's a
slight problem where the new parser omits space between type and
function argument name. E.g. it produces
method(self,inti)
instead of
method(self,int i)
</code></pre></div>
<p dir="auto">Not sure if we should worry about the cython output much - we could also drop the cython unit tests if desired.</p>
<hr>
<h4>You can view, comment on, or merge this pull request online at:</h4>
<p> <a href='https://github.com/geany/geany/pull/3031'>https://github.com/geany/geany/pull/3031</a></p>
<h4>Commit Summary</h4>
<ul>
<li><a href="https://github.com/geany/geany/pull/3031/commits/5eb88a63e04da86d4f30f1d9b4639c41cb6594f1" class="commit-link">5eb88a6</a> Use uctags version of python</li>
<li><a href="https://github.com/geany/geany/pull/3031/commits/a2fda49acaef48701251441f8064bba0eaa478d4" class="commit-link">a2fda49</a> Update mappings in tm_parser.c</li>
<li><a href="https://github.com/geany/geany/pull/3031/commits/f341cc5c197b6fe152e1edf07a64f2450ff80797" class="commit-link">f341cc5</a> Update python unit tests</li>
<li><a href="https://github.com/geany/geany/pull/3031/commits/c966c25120f4d592434254b7ff15ca8d5e7ff76b" class="commit-link">c966c25</a> Update cython tests with a slightly buggy output</li>
</ul>
<h4 style="display: inline-block">File Changes </h4> <p style="display: inline-block">(<a href="https://github.com/geany/geany/pull/3031/files">9 files</a>)</p>
<ul>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3031/files#diff-e0ce68205f4ca660762ddbc1f13f556330aea31c7de950df4da1d4ce6f95e6d6">ctags/Makefile.am</a>
(2)
</li>
<li>
<strong>D</strong>
<a href="https://github.com/geany/geany/pull/3031/files#diff-7d1d4ef6640b00260843729ddaa708bf14b6ffe539274beedb30c71f34250854">ctags/parsers/geany_python.c</a>
(862)
</li>
<li>
<strong>A</strong>
<a href="https://github.com/geany/geany/pull/3031/files#diff-1b1bdaf86a168b8511bbf33a455205afa0c9605046134daf61b69161fa5f05e0">ctags/parsers/python.c</a>
(1597)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3031/files#diff-52c3ba1a920ce03ae524e393cf4d0ff582b13d9eafef29393f9841c19adf31f8">src/tagmanager/tm_parser.c</a>
(4)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3031/files#diff-a3e9f67faad610524d016f45a15a3ea0a19025bc90b2754ed7d47baa505e4c55">tests/ctags/cython_sample.pyx.tags</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3031/files#diff-88a531582c246833915e779f1f289913195e7b9a8ee65a58bc38501c9b957ce1">tests/ctags/cython_sample2.pyx.tags</a>
(2)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3031/files#diff-fdb9d9a182b1e0c01dda943058c1552a2c709743445c85c5e010481a0bb2d50b">tests/ctags/py_constructor_arglist.py.tags</a>
(33)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3031/files#diff-46886995acaf5b91604a3895e9c66f842fbdde364fbc73eecd37c2af538bbbfd">tests/ctags/simple.py.tags</a>
(6)
</li>
<li>
<strong>M</strong>
<a href="https://github.com/geany/geany/pull/3031/files#diff-8370de38951801d301cc7865c50ba5052f5edf4688008b2ff9f1a868abdc9a49">tests/ctags/tabindent.py.tags</a>
(2)
</li>
</ul>
<h4>Patch Links:</h4>
<ul>
<li><a href='https://github.com/geany/geany/pull/3031.patch'>https://github.com/geany/geany/pull/3031.patch</a></li>
<li><a href='https://github.com/geany/geany/pull/3031.diff'>https://github.com/geany/geany/pull/3031.diff</a></li>
</ul>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/3031">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ2AMMRD4Q7KBLU2DZDUOIEURANCNFSM5I5FRUMQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJ3KNGZA4PTXFXDKQRTUOIEURA5CNFSM5I5FRUM2YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4P37HGWQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/3031",
"url": "https://github.com/geany/geany/pull/3031",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>