<p></p>
<p><b>@kugel-</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/3024#discussion_r758074802">src/utils.c</a>:</p>
<pre style='color:#555'>> @@ -2414,6 +2419,48 @@ void utils_start_new_geany_instance(const gchar *doc_path)
 }
 
 
+
+static int get_path_max(const char *path)
+{
+#ifdef PATH_MAX
+       return PATH_MAX;
+#else
+       int path_max = pathconf(path, _PC_PATH_MAX);
+       if (path_max <= 0)
+               path_max = 4096;
+       return path_max;
+#endif
</pre>
<p dir="auto">I think the <code>pathconf</code> code should be the default, and <code>PATH_MAX</code> should only be considered on Windows. On Unix, <code>PATH_MAX</code> is not necessarily a constant.</p>
<p dir="auto">Looks like the code from <code>realpath(3)</code> man page and it discusses problems with that code.</p>
<p dir="auto">Apparently we should be doing <code>realpath(name, NULL)</code> but I'm unsure if it's supported on our relevant platforms?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/3024#pullrequestreview-817405166">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ3XVKUCXIUNJUJ6HSTUOMOZHANCNFSM5I4G3H2A">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJZIPN3FHY22EHXWRMTUOMOZHA5CNFSM5I4G3H2KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOGC4JZ3Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/3024#pullrequestreview-817405166",
"url": "https://github.com/geany/geany/pull/3024#pullrequestreview-817405166",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>