<p></p>
<blockquote>
<p dir="auto">I share the concerns that grey foreground color could interfere with<br>
grey themes. And I actually like the proposed "baby poop brown" :D.</p>
</blockquote>
<p dir="auto">Yeah, it's not baby poop, it's amber :-)</p>
<p dir="auto">We could change the colors this way (had to try the color highlighting on github myself ;-):</p>
<ol dir="auto">
<li><code>#0085ff<span class="ml-1 d-inline-block border circle color-border-subtle" style="background-color: #0085ff; height: 8px; width: 8px;"></span></code> (<code>#0000d0<span class="ml-1 d-inline-block border circle color-border-subtle" style="background-color: #0000d0; height: 8px; width: 8px;"></span></code> before): <code>geany-compiler-message</code></li>
<li><code>#00ba34<span class="ml-1 d-inline-block border circle color-border-subtle" style="background-color: #00ba34; height: 8px; width: 8px;"></span></code> (<code>#007f00<span class="ml-1 d-inline-block border circle color-border-subtle" style="background-color: #007f00; height: 8px; width: 8px;"></span></code> before): <code>geany-document-status-readonly</code></li>
<li><code>#f98600<span class="ml-1 d-inline-block border circle color-border-subtle" style="background-color: #f98600; height: 8px; width: 8px;"></span></code> (<code>#7f0000<span class="ml-1 d-inline-block border circle color-border-subtle" style="background-color: #7f0000; height: 8px; width: 8px;"></span></code> before): <code>geany-compiler-context</code>, <code>geany-document-status-disk-changed</code></li>
<li><code>#e92c2c<span class="ml-1 d-inline-block border circle color-border-subtle" style="background-color: #e92c2c; height: 8px; width: 8px;"></span></code> (<code>#ff0000<span class="ml-1 d-inline-block border circle color-border-subtle" style="background-color: #ff0000; height: 8px; width: 8px;"></span></code> before): <code>geany-compiler-error</code>, <code>geany-terminal-dirty</code>, <code>geany-document-status-changed</code></li>
</ol>
<p dir="auto">Some comments:<br>
The biggest change are the colors for (1) and (3). The original green <code>geany-document-status-readonly</code> has slightly worse legibility in dark themes but it's not that tragic. The red is nearly identical. But I would change these colors too for more unified appearance.</p>
<p dir="auto">The original color <code>#ff7f00<span class="ml-1 d-inline-block border circle color-border-subtle" style="background-color: #ff7f00; height: 8px; width: 8px;"></span></code> for <code>geany-document-status-disk-changed</code> is nearly identical to the new infamous baby poop color <code>#f98600<span class="ml-1 d-inline-block border circle color-border-subtle" style="background-color: #f98600; height: 8px; width: 8px;"></span></code> so we could use the new one.</p>
<p dir="auto">I would keep the pink <code>#ff6666<span class="ml-1 d-inline-block border circle color-border-subtle" style="background-color: #ff6666; height: 8px; width: 8px;"></span></code> for <code>geany-search-entry-no-match</code> - I think it visually matches the new colors nicely and since it's a background color with white text, it has the same legibility in all themes (the selection color <code>geany-search-entry-no-match selection</code> <code>#771111<span class="ml-1 d-inline-block border circle color-border-subtle" style="background-color: #771111; height: 8px; width: 8px;"></span></code> is more or less in the "who cares" category and can stay this way too).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/3013#issuecomment-974792334">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ37QCWXGD34WMRTXP3UNDEDLANCNFSM5IOFTMEA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJ4Q6B7IIY5P4B3SSVTUNDEDLA5CNFSM5IOFTMEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHINCNDQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/3013#issuecomment-974792334",
"url": "https://github.com/geany/geany/pull/3013#issuecomment-974792334",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>