<p></p>
<p><b>@techee</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/1126#discussion_r746941848">projectorganizer/src/prjorg-sidebar.c</a>:</p>
<pre style='color:#555'>> @@ -300,6 +300,181 @@ static void on_follow_active(GtkToggleToolButton *button, G_GNUC_UNUSED gpointer
 }
 
 
+/* returns parent folder of path from get_full_path_for_selection()
+ *   if unable to find parent folder, returns home folder
+ *   otherwise, returns NULL
+ * return path is in locale encoding */
+static gchar *get_folder_for_selection(void)
</pre>
<p dir="auto">Once again, I don't understand why this function has so many tests and is so complicated. Basically, when you right-click some item, there should be a selection; if there's no selection, fall back just to whatever, e.g. the project base path. Basically, just call <code>parent_dir_for_create()</code> (maybe could be renamed to something different as it would be used here now) - use the return value when not NULL, otherwise fall back to project base path.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/1126#discussion_r746942834">projectorganizer/src/t/prjorg-project.h</a>:</p>
<pre style='color:#555'>> @@ -0,0 +1,72 @@
+/*
</pre>
<p dir="auto">What is this file? Was it committed by mistake?</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/1126#discussion_r746943498">projectorganizer/src/prjorg-sidebar.c</a>:</p>
<pre style='color:#555'>> +
+
+void on_open_terminal(G_GNUC_UNUSED GtkMenuItem * menuitem, G_GNUC_UNUSED gpointer user_data)
+{
+       gchar *locale_path, *open_command;
+
+       if(g_file_test(PRJORG_COMMAND_TERMINAL_ALT, G_FILE_TEST_EXISTS))
+       {
+               gchar *alt_command;
+               alt_command = utils_get_real_path(PRJORG_COMMAND_TERMINAL_ALT);
+               open_command = g_path_get_basename(alt_command);
+               g_free(alt_command);
+       }
+       else
+       {
+               /* g_strdup is needed here to prevent segfault on g_free */
</pre>
<p dir="auto">This comment isn't really necessary.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/1126#discussion_r746943635">projectorganizer/src/prjorg-sidebar.c</a>:</p>
<pre style='color:#555'>> +
+               g_free(command);
+               g_free(locale_path);
+       }
+       else
+       {
+               msgwin_status_add(_("Unable to find folder."));
+       }
+}
+
+
+void on_open_terminal(G_GNUC_UNUSED GtkMenuItem * menuitem, G_GNUC_UNUSED gpointer user_data)
+{
+       gchar *locale_path, *open_command;
+
+       if(g_file_test(PRJORG_COMMAND_TERMINAL_ALT, G_FILE_TEST_EXISTS))
</pre>
<p dir="auto">Space after 'if'.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/1126#discussion_r746945059">projectorganizer/src/prjorg-sidebar.c</a>:</p>
<pre style='color:#555'>> +    if(locale_path && !g_file_test(locale_path, G_FILE_TEST_IS_DIR))
+       {
+               g_free(locale_path);
+               locale_path = NULL;
+       }
+
+       return locale_path;
+}
+
+
+void on_open_file_manager(G_GNUC_UNUSED GtkMenuItem * menuitem, G_GNUC_UNUSED gpointer user_data)
+{
+       gchar *locale_path;
+       gchar *open_command;
+
+       open_command = PRJORG_COMMAND_OPEN;
</pre>
<p dir="auto">Can be moved inside the <code>if</code> below and the variable can be <code>const</code>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/1126#pullrequestreview-803085684">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ3ZWKLBCUCNNWOIAPLULLGGXANCNFSM5GTVPZ4Q">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJ2WPONX5TRGI3XUBTLULLGGXA5CNFSM5GTVPZ42YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOF7PB25A.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany-plugins/pull/1126#pullrequestreview-803085684",
"url": "https://github.com/geany/geany-plugins/pull/1126#pullrequestreview-803085684",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>