<p></p>
<p><b>@xiota</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2962#discussion_r744033900">src/build.c</a>:</p>
<pre style='color:#555'>> @@ -1057,7 +1057,7 @@ gboolean build_parse_make_dir(const gchar *string, gchar **prefix)
        if (string == NULL)
                return FALSE;
 
-       if ((pos = strstr(string, "Entering directory")) != NULL)
+       if (strstr(string, "Entering directory") != NULL)
</pre>
<p>What about this, to avoid rescanning the beginning of the string:</p>
<div class="highlight highlight-source-c"><pre><span class="pl-k">if</span> ((pos = strstr(string, <span class="pl-s"><span class="pl-pds">"</span>Entering directory<span class="pl-pds">"</span></span>)) != <span class="pl-c1">NULL</span>)
{
        <span class="pl-c"><span class="pl-c">//</span> ...</span>

        pos = <span class="pl-c1">strstr</span>(pos, <span class="pl-s"><span class="pl-pds">"</span>/<span class="pl-pds">"</span></span>);   <span class="pl-c"><span class="pl-c">//</span> instead of ... pos = strstr(string, "/");</span>

        <span class="pl-c"><span class="pl-c">//</span> ...</span>
}</pre></div>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2962#pullrequestreview-799394905">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ7F4MYSW5H4UDGTHM3UKR7LLANCNFSM5G2EQTXA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJ4YP2WOAEN6FEY66CLUKR7LLA5CNFSM5G2EQTXKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOF6S4YWI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2962#pullrequestreview-799394905",
"url": "https://github.com/geany/geany/pull/2962#pullrequestreview-799394905",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>