<p></p>
<p><b>@elextr</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2930#discussion_r735104170">src/highlightingmappings.h</a>:</p>
<pre style='color:#555'>> @@ -388,7 +388,12 @@ static const HLStyle highlighting_styles_CSS[] =
        { SCE_CSS_EXTENDED_IDENTIFIER,          "extended_identifier",                FALSE },
        { SCE_CSS_EXTENDED_PSEUDOCLASS,         "extended_pseudoclass",               FALSE },
        { SCE_CSS_EXTENDED_PSEUDOELEMENT,       "extended_pseudoelement",     FALSE },
-       { SCE_CSS_MEDIA,                                        "media",                                      FALSE }
+       { SCE_CSS_GROUP_RULE,                           "group_rule",                         FALSE },
+       /* In Geany 1.38 and earlier shipped filetypes.css with "media" identifier,
+        * Scintilla/Lexilla 5.1.2 has renamed this style and extended its meaning.
+        * We still recognize media for compatibility.
+        */
+       { SCE_CSS_GROUP_RULE,                           "media",                                      FALSE }
</pre>
<p>yeah I think the second line needs to be removed so they are two separate syntactic entity names.</p>
<p>Basically I don't think its going to be possible to map the two together in the code as <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/kugel-/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/kugel-">@kugel-</a> wanted to, good try and it would have allowed old colour schemes to handle <code>group_rule</code> unchanged.  But it looks like has to be done in the config file, and colour schemes.</p>
<p>Unless some new magic capability is added to <code>highlightingmappings.h</code> and <code>highlighting.c</code> to provide a backward compatibility feature, its always going to be a problem for colour schemes and filetype configs when syntactic entities change.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2930#discussion_r735104170">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJYRWEQ3ARWCQ6FNMZDUIPUVHANCNFSM5FYCAC7Q">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJZRMQUUMM7KUOLCRKLUIPUVHA5CNFSM5FYCAC72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOF3YEZRQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2930#discussion_r735104170",
"url": "https://github.com/geany/geany/pull/2930#discussion_r735104170",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>