<p></p>
<p><b>@kugel-</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2943#discussion_r730401635">src/editor.c</a>:</p>
<pre style='color:#555'>>  
 static void auto_close_chars(ScintillaObject *sci, gint pos, gchar c)
 {
        const gchar *closing_char = NULL;
-       gint end_pos = -1;
-
-       if (utils_isbrace(c, 0))
-               end_pos = sci_find_matching_brace(sci, pos - 1);
</pre>
<p>Right, but this makes autoclose also next to useless (I have it disabled and would welcome improvements). Since autoclosing now only works if Scintilla doesn't see a matching brace autoclosing does not work most of the time. E.g.:</p>
<pre><code>int foo()
{
   if (x) { // !! no autoclose for {, as Scintilla matches the } at the end of the function
}
</code></pre>
<p><code>()</code> is autoclosed in that example, though. So basically as of now autoclosing works reliably only at the end of documents, otherwise it may seem to work only randomly.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2943#discussion_r730401635">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ5PPZ6R5LEGPOYQQCTUHKZLJANCNFSM5GBHXS3Q">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJ2S2XO63DCJBAN5W7LUHKZLJA5CNFSM5GBHXS32YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOF2J5HMY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2943#discussion_r730401635",
"url": "https://github.com/geany/geany/pull/2943#discussion_r730401635",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>