<p></p>
<p><b>@kugel-</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2930#discussion_r730409042">scintilla/gtk/ScintillaGTK.cxx</a>:</p>
<pre style='color:#555'>> @@ -264,6 +279,12 @@ ScintillaGTK::~ScintillaGTK() {
        }
        ClearPrimarySelection();
        wPreedit.Destroy();
+       if (settingsHandlerId) {
+               g_signal_handler_disconnect(settings, settingsHandlerId);
+       }
+       if (settings) {
+               g_object_unref(settings);
</pre>
<p><a href="https://sourceforge.net/p/scintilla/code/ci/db178448ae7a1049853c8e6e2cdba6f798ec1ed5/" rel="nofollow">https://sourceforge.net/p/scintilla/code/ci/db178448ae7a1049853c8e6e2cdba6f798ec1ed5/</a></p>
<p>I guess we can simply remove the unref as the same fix is alredy applied upstream.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2930#discussion_r730409042">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ7YKXCYO7I2OTU4VWLUHK7XLANCNFSM5FYCAC7Q">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJ6RGDRJ67CEFNTCIIDUHK7XLA5CNFSM5FYCAC72YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOF2J6SFQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2930#discussion_r730409042",
"url": "https://github.com/geany/geany/pull/2930#discussion_r730409042",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>