<p></p>
<p>I'm a too big Autotools noob to really give valueable feedback.</p>
<p>Apart from that, this generally looks good to me and it removes old code!<br>
I cannot judge whether <code>autoreconf</code> does all the things the many manual steps did before. But I guess <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/b4n/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/b4n">@b4n</a> might know and/or we will notice during testing and using. Oh, and we use <code>autoreconf</code> already in G-P.</p>
<p>I tested the code on my Windows cross-build setup and noticed <code>autopoint</code> needs to be installed to run <code>./autogen.sh</code>. Maybe we should check for this dependency?<br>
And maybe also add <code>set -e</code> to the script as it continues even if some of the commands failed:</p>
<pre><code>Processing configure.ac                                                                                                                                                                                               
autoreconf: Entering directory `.'                                                                                                                                                                                    
autoreconf: running: autopoint --force                                                                                                                                                                                
Can't exec "autopoint": No such file or directory at /usr/share/autoconf/Autom4te/FileUtils.pm line 345.                                                                                                              
autoreconf: failed to run autopoint: No such file or directory                                                                                                                                                        
autoreconf: autopoint is needed because this package uses Gettext                                                                                                                                                     
Done. configure skipped.                                                                   
</code></pre>
<p>After installing <code>autopoint</code>, setup works. But the build fails:</p>
<pre><code>Making all in po                                                                                                                                                                                                      
make[2]: Entering directory '/build/geany-build/po'                                                                                                                                                                   
make[2]: Leaving directory '/build/geany-build/po'                                                                                                                                                                    
make[2]: *** No rule to make target 'Makevars', needed by 'Makefile'.  Stop.                                                                                                                                          
make[1]: Leaving directory '/build/geany-build'                                                                                                                                                                       
make[1]: *** [Makefile:589: all-recursive] Error 1                                                                                                                                                                    
make: *** [Makefile:473: all] Error 2                              
</code></pre>
<p>What's missing:</p>
<ul>
<li>docs: we have a couple of occurrences of <code>intltool</code> (Readme, plugins docs, ...), <code>git grep</code> and then search+replace</li>
<li>Travis: we should remove intltool from the CI dependencies and add autopoint</li>
</ul>
<p>P.S.: there was no CI job for this PR because probably me broke the Travis Github integration last week, without purpose. I tried to re-establish the integration again but I'm not completely sure it worked. We'll see with the next push.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2938#issuecomment-945116095">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ6FRSANBVR7F4TEGE3UHLCF5ANCNFSM5F3OMHAQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJYCOE5VCFSGPZPK2P3UHLCF5A5CNFSM5F3OMHA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOHBKVHPY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2938#issuecomment-945116095",
"url": "https://github.com/geany/geany/pull/2938#issuecomment-945116095",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>