<p></p>
<p>It turned out this change fixed only one symptom of the real underlying problem:<br>
<a href="https://gitlab.gnome.org/GNOME/libxml2/-/issues/255" rel="nofollow">https://gitlab.gnome.org/GNOME/libxml2/-/issues/255</a> - some changes in libxml2 2.9.12 in combination with lxml broke the <code>lxml.etree.tostring()</code> method which we also use.<br>
This leads to extra content in the extracted XML elements and this is why we suddenly got non-UTF8 content in the generated GTK doc header (and hence this change was necessary).<br>
Recent nightly builds failed at generating translation files with:</p>
<pre><code>The following files contain translations and are currently not in use. Please
consider adding these to the POTFILES.in file, located in the po/ directory.

doc/geany-gtkdoc.h
</code></pre>
<p>but this was also only a symptom because now the generated file contained more than the filtered content by the generation script.</p>
<p>Luckily, libxml2 got a workaround for this bug and Debian already included this workaround in the latest <code>libxml2</code> package, so future nightly builds on Debian Unstable should work again.</p>
<p>The change in this PR is good anyway and can be kept, I'd say.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2885#issuecomment-917381653">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ3W2DDF6RLFYRP27ITUBMUHHANCNFSM5DMSHWFA">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJ4VPIW4AEYHUQJLZ5DUBMUHHA5CNFSM5DMSHWFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG2XCEFI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2885#issuecomment-917381653",
"url": "https://github.com/geany/geany/pull/2885#issuecomment-917381653",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>