<p></p>
<p>Tested on Windows, also against a x86_64 build and works.</p>
<p>However, Geany didn't crash on my system without the change. I still consider the change as correct.</p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/vlvlbel/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/vlvlbel">@vlvlbel</a> for my curiosity, how do you build Geany? I assume in a Mingw64 shell against  "mingw-w64-x86_64-*" packages? I'm wondering why it didn't crash for me.</p>
<p>For completeness, there are a couple of more occurences with the wrong cast:</p>
<pre><code>geanylua/glspi_sci.c:                   if (len) { scintilla_send_message(doc->editor->sci,SCI_COPYTEXT,len,(glong)content); }
geanymacro/src/geanymacro.c:                    scintilla_send_message(sci,me->message,me->wparam,(glong)clipboardcontents);
geanymacro/src/geanymacro.c:                    me->lparam=(glong)(g_strcompress(s[(*k)++]));
geanymacro/src/geanymacro.c:                            me->lparam=(glong)NULL;
geanymacro/src/geanymacro.c:                    me->lparam=(glong)(g_strcompress(s[(*k)++]));
geanymacro/src/geanymacro.c:            ?((glong) g_strdup((gchar *)(nt->lParam))) : nt->lParam;
geanymacro/src/geanymacro.c:                                    me->lparam=(glong)((cTemp!=NULL)?g_strdup(cTemp):g_strdup(""));
geanymacro/src/geanymacro.c:                                    me->lparam=(glong)(((*cTemp2)==0)?NULL:g_strdup(cTemp2));
geanynumberedbookmarks/src/geanynumberedbookmarks.c:            scintilla_send_message(sci,SCI_MARKERDEFINEPIXMAP,m,(glong)(aszMarkerImages[k]));
git-changebar/src/gcb-plugin.c:  scintilla_send_message (sci, SCI_ADDTEXT, buf_len, (glong) buf);
git-changebar/src/gcb-plugin.c:  scintilla_send_message (old_sci, SCI_ADDTEXT, old_buf_len, (glong) old_buf);
</code></pre>
<p>Should we fix those as well?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/1106#issuecomment-912951650">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ2Z3XASTCQKJURNILTUAHZWPANCNFSM5DLZQ3PQ">unsubscribe</a>.<br />Triage notifications on the go with GitHub Mobile for <a href="https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675">iOS</a> or <a href="https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub">Android</a>.
<img src="https://github.com/notifications/beacon/AAIOWJZ7BGASUM3ZNZY4PTDUAHZWPA5CNFSM5DLZQ3P2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOGZVISYQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany-plugins/pull/1106#issuecomment-912951650",
"url": "https://github.com/geany/geany-plugins/pull/1106#issuecomment-912951650",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>