<p></p>
<p><b>@elextr</b> requested changes on this pull request.</p>

<p>First glance at it only a few comments, also for the Julia lexer could you add a diff that applies the three lines (I think you said) to backport it from Lexilla, probably best in the same place as scintilla_changes.patch and add a prompt to update_scintilla.sh to use it so the changes are known and can be re-applied if another backport is needed.</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/2584#discussion_r654899211">data/filedefs/filetypes.common</a>:</p>
<pre style='color:#555'>> @@ -129,14 +129,15 @@ comment_line_doc=comment_doc
 comment_doc_keyword=comment_doc,bold
 comment_doc_keyword_error=comment_doc,italic
 
-number=0x007f00
+number=0x808000
</pre>
<p>Why the change to the default colour scheme?</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2584#discussion_r654900257">data/snippets.conf</a>:</p>
<pre style='color:#555'>> @@ -138,3 +138,3283 @@ module=-module(%cursor%).
 export=-export(%cursor%).
 compile=-compile(%cursor%).
 include=-include(%cursor%).
+
+[Julia]
</pre>
<p>This is a cunning way of getting the Julia latex input to work in Geany :-) but IIRC all the snippets for all languages are read at startup, is there a way this could be distributed in another way instead of every user of every language having several thousand Julia snippets loaded?  As a user snippets somehow maybe?</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2584#discussion_r654901390">data/filedefs/filetypes.common</a>:</p>
<pre style='color:#555'>> @@ -153,6 +154,7 @@ identifier_4=identifier_1
 string=0xff8000
 string_1=string
 string_2=0x008000
+string_3=0x008000
</pre>
<p>Is this used?</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2584#discussion_r654901653">data/filedefs/filetypes.julia</a>:</p>
<pre style='color:#555'>> +# MIME type
+mime_type=text/x-julia
+
+# single comments, like # in this file
+comment_single=#
+# multiline comments
+comment_open=#=
+comment_close==#
+
+[indentation]
+width=4
+# 0 is spaces, 1 is tabs, 2 is tab & spaces
+type=0
+
+
+[build_settings]
</pre>
<p>Please use the <code>[build_menu]</code> settings, all the old filetypes still use <code>[build_settings]</code> because I made the backwards compat too good and nobody has needed to change them :-) but lets make it right for new ones.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2584#pullrequestreview-687881603">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ2FVBBWCZEZLAKRAD3TTWVEHANCNFSM4RIBU6VA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJ6HEHPJPFRIXGYNY4LTTWVEHA5CNFSM4RIBU6VKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOFEAD3AY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2584#pullrequestreview-687881603",
"url": "https://github.com/geany/geany/pull/2584#pullrequestreview-687881603",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>