<p></p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/codebrainz/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/codebrainz">@codebrainz</a> Correct, intention is <strong>1</strong>. I closed the old PR because of the branch issue <strong>and</strong> because I changed the PL to also apply to <em>Search > Find in Files</em>.</p>
<p>If I understand your patch correct, it would change the default behaviour to do exactly that what my PL does, but per default and without a hidden preference. This is of course up to you, but I think a hidden preference may be better than changing the default behaviour without allowing users to fall back to the old default behaviour. My PL would resolve this issue. We could also just change the default value for <em>search.always_set_from_selected</em> from <em>false</em> to <em>true</em>.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2697#issuecomment-749163226">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ4DN266AL3QEJBYGS3SV6QRVANCNFSM4VD57AXA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJ74ALVQGT5LN4QOSJDSV6QRVA5CNFSM4VD57AXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFSTVFWQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2697#issuecomment-749163226",
"url": "https://github.com/geany/geany/pull/2697#issuecomment-749163226",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>