<p></p>
<blockquote>
<p>As I keep saying C++ is not C <g-emoji class="g-emoji" alias="grin" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f601.png">😁</g-emoji></p>
</blockquote>
<p>I know, and I battle for avoiding this confusion.  I just see once more that C++ tries to be confusing for C programmers, reproducing syntax but with a whole other lot of constraint that only apply in corner cases <g-emoji class="g-emoji" alias="grin" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f601.png">😁</g-emoji></p>
<p>Anyhow, a bad patch could be as simple as:</p>
<div class="highlight highlight-source-diff"><pre><span class="pl-c1">diff --git a/scintilla/src/Indicator.cxx b/scintilla/src/Indicator.cxx</span>
index f72102772..5c076290b 100644
<span class="pl-md">--- a/scintilla/src/Indicator.cxx</span>
<span class="pl-mi1">+++ b/scintilla/src/Indicator.cxx</span>
<span class="pl-mdr">@@ -64,6 +64,8 @@</span> void Indicator::Draw(Surface *surface, const PRectangle &rc, const PRectangle &r
                        const PRectangle rcSquiggle = PixelGridAlign(rc);
 
                        const int width = std::min(4000, static_cast<int>(rcSquiggle.Width()));
<span class="pl-mi1"><span class="pl-mi1">+</span>                        if (width < 1)</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>                                break;</span>
                        RGBAImage image(width, 3, 1.0, nullptr);
                        enum { alphaFull = 0xff, alphaSide = 0x2f, alphaSide2=0x5f };
                        for (int x = 0; x < width; x++) {</pre></div>
<p>It solves the very problem here, but doesn't fix it more generally than just for the squiggles.</p>
<p>Unfortunately just fixing the pixels retrieval is not enough, there's at least one other instance of an empty vector access down the same code path.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/issues/1041#issuecomment-739925758">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ5NBY5IZUX73W4HDA3STTLULANCNFSM4UHMIKQQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJ663GFF3F32BGJFGP3STTLULA5CNFSM4UHMIKQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFQNF57Q.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany-plugins/issues/1041#issuecomment-739925758",
"url": "https://github.com/geany/geany-plugins/issues/1041#issuecomment-739925758",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>