<p></p>
<blockquote>
<p>There are six test samples which have CRLF line endings which still causes the tests to fail. Those could be converted to LF line endings:</p>
<pre><code>* 3184782.sql.tags

* 3526726.tex.tags

* bug1570779.sql.tags

* ingres_procedures.sql.tags

* matlab_backtracking.m.tags

* matlab_test.m.tags
</code></pre>
</blockquote>
<p>That' super duper weird, it's exactly the ones that would fail would CTags not normalize line ends itself (which it does).  If I manually remove that piece of code, I get those failures on Linux:</p>
<div class="highlight highlight-source-diff"><pre><span class="pl-c1">diff --git a/ctags/main/read.c b/ctags/main/read.c</span>
index e19f15697..3586a1aaa 100644
<span class="pl-md">--- a/ctags/main/read.c</span>
<span class="pl-mi1">+++ b/ctags/main/read.c</span>
<span class="pl-mdr">@@ -857,7 +857,7 @@</span> static eolType readLine (vString *const vLine, MIO *const mio)
          * used forms of line breaks are: LF (UNIX/Mac OS X), CR-LF (MS-DOS) and
          * CR (Mac OS 9). As CR-only EOL isn't handled by gets() and Mac OS 9
          * is dead, we only handle CR-LF EOLs and convert them into LF. */
<span class="pl-md"><span class="pl-md">-</span>        if (newLine && vStringLength (vLine) > 1 &&</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>        if (false && newLine && vStringLength (vLine) > 1 &&</span>
             vStringChar (vLine, vStringLength (vLine) - 2) == '\r')
         {
             vStringChar (vLine, vStringLength (vLine) - 2) = '\n';</pre></div>
<p>I really don't understand how Windows would make any difference here, I don't see any code being conditional around there.  And even if the libc was doing the conversion CRLF→LF behind the scenes, that should not be a problem either (unless maybe if there's a bug in the libc regarding fgetpos/fsetpos after such mappings, but I wouldn't expect this kind of breakage).</p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/eht16/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/eht16">@eht16</a> Could you check what exactly is the return value of the <code>mio_gets()</code> calls in <code>readLine()</code> (or <code>iFileReadLine()</code> before <em>ctags_sync5</em>)?  The only explanation I have is that it doesn't return the format expected by this code -- which would be surprising, but well.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/issues/2677#issuecomment-736096680">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ5GERSRYOKI4BAARYDSSQMXFANCNFSM4UGQMLEQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJ27KPSKAWYNRZFE7RLSSQMXFA5CNFSM4UGQMLE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFPP7DKA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/issues/2677#issuecomment-736096680",
"url": "https://github.com/geany/geany/issues/2677#issuecomment-736096680",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>