<p></p>
<blockquote>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/techee/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/techee">@techee</a> IIUC the problem is with tag files that have CRLF line endings, not source files getting parsed. If that's so, it won't change nothing there, at worse we need special handling to support CRLF and LF not to break compatibility.</p>
</blockquote>
<p>Maybe I miss something but that's not my impression with the failed SQL tests - it's the tests themselves that have CRLFs in the code and the tag file diff is this based on Enrico's output. There are several tags missing and I think the missing tags are caused by the CRLFs in the test:</p>
<pre><code>--- ./ingres_procedures.sql.tags 2016-06-12 17:16:40.683765400 +0200
+++ /tmp/tmp.2xGTegTO88/test.sql.tags   2020-11-25 23:33:27.945656500 +0100
@@ -1,7 +1,3 @@
 # format=tagmanager
 db0001Ì256Ö0
-db0002Ì256Ö0
-db0003Ì256Ö0
-errÌ16384Ö0
-nÌ16384Ö0
 xÌ16384Ö0
FAIL ingres_procedures.sql.tags (exit status: 2)
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2666#issuecomment-735724637">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ3FGMXVCKW734JXALDSSN5WDANCNFSM4T2VTWXA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJ6SRZY5BQXK6FXT2EDSSN5WDA5CNFSM4T2VTWXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFPNEIXI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2666#issuecomment-735724637",
"url": "https://github.com/geany/geany/pull/2666#issuecomment-735724637",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>