<p></p>
<blockquote>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/eht16/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/eht16">@eht16</a> yay, thanks! I just committed your fix slightly modified to improve overall ordering of the checks, but it should have the same result.</p>
</blockquote>
<p>Confirmed. Your changes work fine !</p>
<blockquote>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/eht16/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/eht16">@eht16</a> however, did the bundled regex got used, or did your MSYS have <code>regcomp()</code>? Same question for <code>fnmathc()</code>. If MSYS has it, it's less relevant for us to bundle it, and maybe we should have a way of using that in the Travis builds instead?</p>
</blockquote>
<pre><code>...
checking fnmatch.h usability... no
checking fnmatch.h presence... no
checking for fnmatch.h... no
...
checking for regcomp... no
...
</code></pre>
<p>Full build log with all the boring details at <a href="https://gist.github.com/eht16/895090eddc23c6d241eb2cbec25159c0#file-build-log">https://gist.github.com/eht16/895090eddc23c6d241eb2cbec25159c0#file-build-log</a>.<br>
At the end of the build log is the result of <code>make check</code> with all tests failed :(.<br>
But luckily this was just because the sample files have LF line endings and the generated tag files have CRLF.<br>
As a quick hack I added <code>--strip-trailing-cr</code> to <code>runner.sh</code> (<a href="https://gist.github.com/eht16/895090eddc23c6d241eb2cbec25159c0#file-runner-sh-diff">https://gist.github.com/eht16/895090eddc23c6d241eb2cbec25159c0#file-runner-sh-diff</a>) and the results looked way better. Still a few tests failed.</p>
<p>I didn't check why the tests fail but here is the log:<br>
<a href="https://gist.github.com/eht16/895090eddc23c6d241eb2cbec25159c0#file-test-suite-log">https://gist.github.com/eht16/895090eddc23c6d241eb2cbec25159c0#file-test-suite-log</a></p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2666#issuecomment-733978563">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ5PU4F3DBND22B25U3SRWCL7ANCNFSM4T2VTWXA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJZC5GEISM2WS5OWAQLSRWCL7A5CNFSM4T2VTWXKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFO7Z7QY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2666#issuecomment-733978563",
"url": "https://github.com/geany/geany/pull/2666#issuecomment-733978563",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>