<p></p>
<p><b>@b4n</b> approved this pull request.</p>

<p>LGTM! <g-emoji class="g-emoji" alias="tada" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f389.png">🎉</g-emoji> <g-emoji class="g-emoji" alias="partying_face" fallback-src="https://github.githubassets.com/images/icons/emoji/unicode/1f973.png">🥳</g-emoji></p>
<p><a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/geany/geany/commit/04eec181710a1e8537b7f4f83e98658e3cf18907/hovercard" href="https://github.com/geany/geany/commit/04eec181710a1e8537b7f4f83e98658e3cf18907"><tt>04eec18</tt></a>, <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/geany/geany/commit/2927ec4dbb139528a07209d551897098425f3ebe/hovercard" href="https://github.com/geany/geany/commit/2927ec4dbb139528a07209d551897098425f3ebe"><tt>2927ec4</tt></a>, <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/geany/geany/commit/99a993fbfed30075610a30432ffe5ae1c3ae2fc3/hovercard" href="https://github.com/geany/geany/commit/99a993fbfed30075610a30432ffe5ae1c3ae2fc3"><tt>99a993f</tt></a>, <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/geany/geany/commit/3847b6c2a9e090a3362d35dac51c3859f628cacd/hovercard" href="https://github.com/geany/geany/commit/3847b6c2a9e090a3362d35dac51c3859f628cacd"><tt>3847b6c</tt></a> and <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/geany/geany/commit/ccd5330a21318a0f39bcaf330dac1188e25ab6aa/hovercard" href="https://github.com/geany/geany/commit/ccd5330a21318a0f39bcaf330dac1188e25ab6aa"><tt>ccd5330</tt></a> could be squashed in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/geany/geany/commit/353ceff30518ea0291a1f8cae279d66dd0a1c469/hovercard" href="https://github.com/geany/geany/commit/353ceff30518ea0291a1f8cae279d66dd0a1c469"><tt>353ceff</tt></a> if you like, but it's fine with me as is -- and possibly even better, I'm not completely sure which way I like best.</p>
<p>Apart from that, there's basically no change in the non-main part diff, so there's not much to add to v4 :)</p>
<p>I'll also try and take a look at importing upstream bundled regex library to at least get Jenkins happy, and we can always use another dep later -- unless <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/codebrainz/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/codebrainz">@codebrainz</a> or <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/eht16/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/eht16">@eht16</a> have another solution at hand?</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2666#pullrequestreview-535985504">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ7RA6E5RHDOPVA7EEDSRAACVANCNFSM4T2VTWXA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJYWIBKG44BA25VMUFLSRAACVA5CNFSM4T2VTWXKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD7ZH2YA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2666#pullrequestreview-535985504",
"url": "https://github.com/geany/geany/pull/2666#pullrequestreview-535985504",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>