<p></p>
<p><b>@eht16</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2590#discussion_r519184156">scripts/gtk-bundle-from-msys2.sh</a>:</p>
<pre style='color:#555'>>                      fi
                done
-               rmdir mingw32
+               rmdir mingw64
+       fi
+}
+
+delayed_post_install() {
+       if [ "$run_pi" ]; then
+               echo "Execute delayed post install tasks"
+               # Commands have been collected manually from the various .INSTALL scripts
</pre>
<p>Yes, it is fragile. But no more than having them executed during package extraction:</p>
<pre><code>Running post_install script for "glib2"
.INSTALL: line 3: pwd: -W: invalid option
pwd: usage: pwd [-LP]
/build
sed: can't read /bin/gdbus-codegen-script.py: No such file or directory
sed: can't read /bin/glib-genmarshal-script.py: No such file or directory
sed: can't read /bin/glib-mkenums-script.py: No such file or directory
sed: can't read /bin/gtester-report-script.py: No such file or directory
</code></pre>
<p>They use <code>pwd -W</code> which is a MSYS special option and exist in no other <code>pwd</code> implementation.</p>
<p>And it continues:</p>
<pre><code>Running post_install script for "fontconfig"

  Fontconfig configuration is done via /mingw64/etc/fonts/conf.avail and conf.d.
  Read /mingw64/etc/fonts/conf.d/README for more information.

updating font cache... .INSTALL: line 13: mingw64/bin/fc-cache: No such file or directory
done.
Running post_install script for "gdk-pixbuf2"
.INSTALL: line 2: mingw64/bin/gdk-pixbuf-query-loaders: No such file or directory
Running post_install script for "hicolor-icon-theme"
.INSTALL: line 9: mingw64/bin/gdk-pixbuf-query-loaders.exe: cannot execute binary file: Exec format error
Running post_install script for "adwaita-icon-theme"
.INSTALL: line 9: mingw64/bin/gdk-pixbuf-query-loaders.exe: cannot execute binary file: Exec format error
</code></pre>
<p>Many of the scripts don't work properly and much of the stuff in there we don't need.<br>
We could maybe patch the install scripts so that they work with <code>wine</code> and replace <code>pwd -W</code> but this feels even more fragile.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2590#discussion_r519184156">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ22M4YAQDIIMRXBVOTSOVMGJANCNFSM4RTUWQYA">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJ2QRXBEO4ZCGRG5T2DSOVMGJA5CNFSM4RTUWQYKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOD5KOKVQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2590#discussion_r519184156",
"url": "https://github.com/geany/geany/pull/2590#discussion_r519184156",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>