<p></p>
<p>Should we merge this for 1.37?  The advantage is that <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="439121235" data-permission-text="Title is private" data-url="https://github.com/geany/geany/issues/2140" data-hovercard-type="pull_request" data-hovercard-url="/geany/geany/pull/2140/hovercard" href="https://github.com/geany/geany/pull/2140">#2140</a> has landed in this window, so reverting it now would impact fewer users.  For the rest, see above.</p>
<p>I believe this is stable and safe, but feel free to disagree.</p>
<p>I did a last minute addition, that is properly recalculate margins sizes when changing the font.  This can be left out if wanted, it's not critical for the feature, and we already have a bug there that line numbers margin wasn't resized eithe: try setting a font size super small (e.g. 4pt), restart Geany (or zoom in/out), and then set a larger font size (let's say 12pt): line numbers will be cropped. So I guess it's not something common enough that people notice.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/1738#issuecomment-716121373">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ3FXGBNY4TMT4VSEWDSMPZIHANCNFSM4ELPKN4A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJ26HM2LWUIA4AZDWCTSMPZIHA5CNFSM4ELPKN4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOFKXSKHI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/1738#issuecomment-716121373",
"url": "https://github.com/geany/geany/pull/1738#issuecomment-716121373",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>