<p></p>
<p><b>@eht16</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2610#discussion_r499155999">configure.ac</a>:</p>
<pre style='color:#555'>>  
 gtk2_package=gtk+-2.0
 gtk2_min_version=2.24
 gtk3_package=gtk+-3.0
 gtk3_min_version=3.0
 
-PKG_CHECK_EXISTS([$gtk2_package >= $gtk2_min_version], [have_gtk2=yes], [have_gtk2=no])
-PKG_CHECK_EXISTS([$gtk3_package >= $gtk3_min_version], [have_gtk3=yes], [have_gtk3=no])
-AS_IF([test "x$enable_gtk3" = xyes || (test "x$enable_gtk3" != xno &&
-                                                                          test "x$have_gtk3" = xyes &&
-                                                                          test "x$have_gtk2" = xno)],
-         [gtk_package=$gtk3_package
-          gtk_min_version=$gtk3_min_version],
-         [gtk_package=$gtk2_package
-          gtk_min_version=$gtk2_min_version])
+AS_IF([test "x$enable_gtk2" = "xyes"],
+       [PKG_CHECK_MODULES([GTK],
</pre>
<p>Why the new check with <code>PKG_CHECK_MODULES</code>?<br>
This seems to cause the linking errors (though no idea why it happens only with Mingw builds).</p>
<p>Without <code>PKG_CHECK_MODULES</code>, it works fine for the Mingw build and is closer to the original code:</p>
<pre><code>AS_IF([test "x$enable_gtk2" = "xyes"],
                [gtk_package=$gtk2_package
                 gtk_min_version=$gtk2_min_version],
                [gtk_package=$gtk3_package
                 gtk_min_version=$gtk3_min_version])
</code></pre>
<p>We actually just set the variables for the <code>PKG_CHECK_MODULES</code> check further below.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2610#pullrequestreview-501552849">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ6M3YIX7HCKLZ2B3N3SI45TLANCNFSM4SCAANGQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJ4UMQ5CI36NMLIW2JDSI45TLA5CNFSM4SCAANG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODXSRNUI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2610#pullrequestreview-501552849",
"url": "https://github.com/geany/geany/pull/2610#pullrequestreview-501552849",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>