<p></p>
<p><b>@codebrainz</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2550#discussion_r456744687">src/notebook.c</a>:</p>
<pre style='color:#555'>> @@ -455,6 +455,34 @@ static void on_close_documents_right_activate(GtkMenuItem *menuitem, GeanyDocume
 }
 
 
+static void on_copy_basename_to_clipboard_activate(GtkMenuItem *menuitem, GeanyDocument *doc)
+{
+       g_return_if_fail(doc->is_valid);
+       
+       gchar *bname = g_path_get_basename(doc->real_path);
+       gtk_clipboard_set_text(gtk_clipboard_get(GDK_NONE), bname, -1);
</pre>
<p>I take <a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/elextr/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/elextr">@elextr</a>'s +1/thumbs-up that I may be correct.</p>
<p>I think it should be like this:</p>
<div class="highlight highlight-source-diff"><pre><span class="pl-c1">diff --git a/src/notebook.c b/src/notebook.c</span>
index cef5375f9..fb47ec29d 100644
<span class="pl-md">--- a/src/notebook.c</span>
<span class="pl-mi1">+++ b/src/notebook.c</span>
<span class="pl-mdr">@@ -460,8 +460,10 @@</span> static void on_copy_basename_to_clipboard_activate(GtkMenuItem *menuitem, GeanyD
        g_return_if_fail(doc->is_valid);
        
        gchar *bname = g_path_get_basename(doc->real_path);
<span class="pl-md"><span class="pl-md">-</span>  gtk_clipboard_set_text(gtk_clipboard_get(GDK_NONE), bname, -1);</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>        gchar *utf8_bname = utils_get_utf8_from_locale(bname);</span>
        g_free(bname);
<span class="pl-mi1"><span class="pl-mi1">+</span>        gtk_clipboard_set_text(gtk_clipboard_get(GDK_NONE), utf8_bname, -1);</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>        g_free(utf8_bname);</span>
 }
 
 
<span class="pl-mdr">@@ -469,7 +471,9 @@</span> static void on_copy_full_path_to_clipboard_activate(GtkMenuItem *menuitem, Geany
 {
        g_return_if_fail(doc->is_valid);
        
<span class="pl-md"><span class="pl-md">-</span>  gtk_clipboard_set_text(gtk_clipboard_get(GDK_NONE), doc->real_path, -1);</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>        gchar *utf8_fname = utils_get_utf8_from_locale(doc->real_path);</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>        gtk_clipboard_set_text(gtk_clipboard_get(GDK_NONE), utf8_fname, -1);</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>        g_free(utf8_fname);</span>
 }
 
 
<span class="pl-mdr">@@ -478,8 +482,10 @@</span> static void on_copy_dir_path_to_clipboard_activate(GtkMenuItem *menuitem, GeanyD
        g_return_if_fail(doc->is_valid);
 
        gchar *dirpath = g_path_get_dirname(doc->real_path);
<span class="pl-md"><span class="pl-md">-</span>  gtk_clipboard_set_text(gtk_clipboard_get(GDK_NONE), dirpath, -1);</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>        gchar *utf8_dirpath = utils_get_utf8_from_locale(dirpath);</span>
        g_free(dirpath);
<span class="pl-mi1"><span class="pl-mi1">+</span>        gtk_clipboard_set_text(gtk_clipboard_get(GDK_NONE), utf8_dirpath, -1);</span>
<span class="pl-mi1"><span class="pl-mi1">+</span>        g_free(utf8_dirpath);</span>
 }
 
 </pre></div>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2550#discussion_r456744687">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ2O4LMKGKZIIMBHPNTR4EMCRANCNFSM4O6VNGHQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJ5AS7DYAMGWFGABIJDR4EMCRA5CNFSM4O6VNGH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODLRCNHI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2550#discussion_r456744687",
"url": "https://github.com/geany/geany/pull/2550#discussion_r456744687",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>