<p></p>
<p><b>@codebrainz</b> requested changes on this pull request.</p>

<p>Seems reasonable.</p>
<p>Aside from the inline comments, I find the labels to be a little ambiguous, I had to look at the code to see how they were different.</p>
<p>Maybe something like these?</p>
<ul>
<li>Copy Basename to Clipboard</li>
<li>Copy Full Path to Clipboard</li>
<li>Copy Directory Path to Clipboard</li>
</ul>
<p>Also the labels should probably have "mnemonics" like the existing items have, like for the above suggested labels, one possibility is to add underscores before B, F and D, respectively.</p>
<p>Only other comment, and maybe it's just how Github is displaying it, but the indentation seems to be too far (ie. 2 tabs where 1 would do), but I haven't checked out the code locally to see if that's actually a problem</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/2550#discussion_r456720739">src/notebook.c</a>:</p>
<pre style='color:#555'>> @@ -455,6 +455,30 @@ static void on_close_documents_right_activate(GtkMenuItem *menuitem, GeanyDocume
 }
 
 
+static void on_copy_filename_to_clipboard_activate(GtkMenuItem *menuitem, GeanyDocument *doc)
+{
+               g_return_if_fail(doc->is_valid);
+
+               gtk_clipboard_set_text(gtk_clipboard_get(GDK_NONE), g_path_get_basename(doc->real_path), -1);
</pre>
<p><code>g_path_get_basename()</code> returns an allocated string that needs to be <code>g_free()</code>'d.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2550#discussion_r456720849">src/notebook.c</a>:</p>
<pre style='color:#555'>> +}
+
+
+static void on_copy_file_path_to_clipboard_activate(GtkMenuItem *menuitem, GeanyDocument *doc)
+{
+               g_return_if_fail(doc->is_valid);
+
+               gtk_clipboard_set_text(gtk_clipboard_get(GDK_NONE), doc->real_path, -1);
+}
+
+
+static void on_copy_file_dir_to_clipboard_activate(GtkMenuItem *menuitem, GeanyDocument *doc)
+{
+               g_return_if_fail(doc->is_valid);
+
+               gtk_clipboard_set_text(gtk_clipboard_get(GDK_NONE), g_path_get_dirname(doc->real_path), -1);
</pre>
<p>Same as above, need to free result of <code>g_path_get_dirname()</code>.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2550#discussion_r456721296">src/notebook.c</a>:</p>
<pre style='color:#555'>> @@ -509,6 +533,37 @@ static void show_tab_bar_popup_menu(GdkEventButton *event, GeanyDocument *doc)
        gtk_container_add(GTK_CONTAINER(menu), menu_item);
        g_signal_connect(menu_item, "activate", G_CALLBACK(on_close_all1_activate), NULL);
 
+       menu_item = gtk_separator_menu_item_new();
+       gtk_widget_show(menu_item);
+       gtk_container_add(GTK_CONTAINER(menu), menu_item);
+
+               menu_item = ui_image_menu_item_new(GTK_STOCK_PASTE, _("Copy filename to clipboard"));
</pre>
<p>I notice the existing menu items use Title Case for the labels, like "Copy Filename to Clipboard".</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2550#pullrequestreview-451009724">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ7GUCLCQTALCJNLQGLR4DS7JANCNFSM4O6VNGHQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJ6NCL7F2ZL5D6XDH7DR4DS7JA5CNFSM4O6VNGH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGODLQ5ZPA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2550#pullrequestreview-451009724",
"url": "https://github.com/geany/geany/pull/2550#pullrequestreview-451009724",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>