<p></p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/ell1e/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/ell1e">@ell1e</a> what is "common"? This is hard to define in a general way and the JSON standard does <em>not</em> allow comments.</p>
<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/users/d5l6/hovercard" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/d5l6">@d5l6</a> I wonder if it wouldn't be better to keep the custom filetype and just add the Scintilla JSON lexer to Geany and update the custom filetype definition to use it.<br>
Otherwise we need also a migration path for existing users or they will end up with two JSON filetypes. Not sure which one would be used then.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2454#issuecomment-629520411">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ7P2IP4N27MNWL4YXTRRW4ETANCNFSM4LN4L75A">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJ6SR7GE54FZMZ3E5ETRRW4ETA5CNFSM4LN4L75KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEWC3QGY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2454#issuecomment-629520411",
"url": "https://github.com/geany/geany/pull/2454#issuecomment-629520411",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>