<blockquote>
<p>Sorry, I meant to write disabling notebook tab close buttons.</p>
</blockquote>
<p>I didn't even realize that option existed until now. I would guess users who do that, it is because they use the keybindings.</p>
<blockquote>
<p>One downside to this is that you have to move the mouse further to click the menu button than before... A simpler solution to this pull would be to move the fixed commands above the notebook tab item list.</p>
</blockquote>
<p>I was going to suggest doing that until I saw this PR for splitting it which seems nicer. I personally don't think it's a big deal that you move your mouse to a different location.</p>
<blockquote>
<p>But we should also consider frequency of use - I would guess Close would be used more often than Open in New Window.</p>
</blockquote>
<p>I would guess the large majority of users don't disable the tab close buttons and of those that do, don't use the menu to close tabs. Personally I don't think I've <em>ever</em> used to item to close a single document from that menu, though I use all of the others often.</p>
<blockquote>
<p>Closing a single document is not a drastic action.</p>
</blockquote>
<p>Indeed, but it's more "drastic" than not closing any document.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2348?email_source=notifications&email_token=AAIOWJ73UMJWTRXQKJ5F3SLQOEHBRA5CNFSM4I7B3WG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBBPMAI#issuecomment-541259265">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ5KF7RAD3RRTT5PK2TQOEHBRANCNFSM4I7B3WGQ">unsubscribe</a>.<img src="https://github.com/notifications/beacon/AAIOWJZJ6ASXPDTW7D2CVHLQOEHBRA5CNFSM4I7B3WG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBBPMAI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2348?email_source=notifications\u0026email_token=AAIOWJ73UMJWTRXQKJ5F3SLQOEHBRA5CNFSM4I7B3WG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBBPMAI#issuecomment-541259265",
"url": "https://github.com/geany/geany/pull/2348?email_source=notifications\u0026email_token=AAIOWJ73UMJWTRXQKJ5F3SLQOEHBRA5CNFSM4I7B3WG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBBPMAI#issuecomment-541259265",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>