<p><b>@LarsGit223</b> requested changes on this pull request.</p>

<p>The gtk version checks are not correct. This will break on systems between gtk version 3.0 and 3.4.</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/2340#discussion_r331787992">src/tools.c</a>:</p>
<pre style='color:#555'>> @@ -828,20 +842,27 @@ void tools_color_chooser(const gchar *color)
 
        if (ui_widgets.open_colorsel == NULL)
        {
+#if (gtk_major_version == 3)   
+               ui_widgets.open_colorsel = gtk_color_chooser_dialog_new(_("Color Chooser"), GTK_WINDOW(main_widgets.window));
</pre>
<p><code>gtk_color_chooser_dialog_new()</code> requires at least gtk version 3.4 not 3. You could use <code>#if GTK_CHECK_VERSION(3, 4, 0) ... else ... endif</code> for a correct version check.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2340#discussion_r331788045">src/tools.c</a>:</p>
<pre style='color:#555'>>                      GeanyDocument *doc = document_get_current();
+                       g_return_if_fail(doc != NULL);
+#if (gtk_major_version == 3)
+                       GdkRGBA color;
+                       char hex[8] = { 0 };
+
+                       gtk_color_chooser_get_rgba(GTK_COLOR_CHOOSER(ui_widgets.open_colorsel), &color);
+                       sprintf(hex, "#%02X%02X%02X",
</pre>
<p>This requires version 3.4 not 3.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2340?email_source=notifications&email_token=AAIOWJ3TH3STBHVRE43DM2DQNHOCRA5CNFSM4I53VIA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHAKFEY#pullrequestreview-297837203">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ6RNOLWLQZHTZJ7BVLQNHOCRANCNFSM4I53VIAQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJZTIP4NNJAZFG5673LQNHOCRA5CNFSM4I53VIA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHAKFEY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2340?email_source=notifications\u0026email_token=AAIOWJ3TH3STBHVRE43DM2DQNHOCRA5CNFSM4I53VIA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHAKFEY#pullrequestreview-297837203",
"url": "https://github.com/geany/geany/pull/2340?email_source=notifications\u0026email_token=AAIOWJ3TH3STBHVRE43DM2DQNHOCRA5CNFSM4I53VIA2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHAKFEY#pullrequestreview-297837203",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>