<p><b>@elextr</b> requested changes on this pull request.</p>

<p>The use-case makes sense now that its explained clearly.</p><hr>

<p>In <a href="https://github.com/geany/geany/pull/2336#discussion_r331236889">src/highlighting.c</a>:</p>
<pre style='color:#555'>> + * @return A pointer to the style struct.
+ */
+GEANY_API_SYMBOL
+const GeanyLexerStyle *highlighting_get_named_style(const gchar *named_style)
+{
+       GeanyLexerStyle *cs;
+       gchar *comma, *name = NULL;
+
+       g_return_val_if_fail(named_style, NULL);
+       name = utils_strdupa(named_style);      /* named_style must not be written to, may be a static string */
+
+       comma = strstr(name, ",");
+       if (comma)
+       {
+               *comma = '\0';  /* terminate name to make lookup work */
+       }
</pre>
<p>Whats this doing? If you pass a name why does it need to terminate at a comma?  Either this is functionality specific to the particular useage, in which case it should be in the caller, or it should be documented behaviour with an explanation of why.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2336?email_source=notifications&email_token=AAIOWJ766MOI6S2IWRJ22STQMZI5XA5CNFSM4I5GGL7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG25UDQ#pullrequestreview-297130510">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ423XIF54RAFSYLJ3LQMZI5XANCNFSM4I5GGL7A">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ764Q6WJN2W635HDT3QMZI5XA5CNFSM4I5GGL7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG25UDQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2336?email_source=notifications\u0026email_token=AAIOWJ766MOI6S2IWRJ22STQMZI5XA5CNFSM4I5GGL7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG25UDQ#pullrequestreview-297130510",
"url": "https://github.com/geany/geany/pull/2336?email_source=notifications\u0026email_token=AAIOWJ766MOI6S2IWRJ22STQMZI5XA5CNFSM4I5GGL7KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCG25UDQ#pullrequestreview-297130510",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>