<p><b>@b4n</b> approved this pull request.</p>

<p>LGTM.  Indeed, we didn't handle the case where the theme would set a specific foreground color for the selected text, separate from the one for unselected text.<br>
I don't have such a theme, but the changes here look sensible to me, and should be harmless otherwise (but if someone changed the colors and now has to override this as well, but that's something I think we can live with).</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2333?email_source=notifications&email_token=AAIOWJ6H4N6EWB34PANRHU3QMOZ5FA5CNFSM4I4N6WG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGRNWNY#pullrequestreview-295885623">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ4MZR5JK4WGUUEOHN3QMOZ5FANCNFSM4I4N6WGQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ2BXN4CFMTNJJF5N53QMOZ5FA5CNFSM4I4N6WG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGRNWNY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2333?email_source=notifications\u0026email_token=AAIOWJ6H4N6EWB34PANRHU3QMOZ5FA5CNFSM4I4N6WG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGRNWNY#pullrequestreview-295885623",
"url": "https://github.com/geany/geany/pull/2333?email_source=notifications\u0026email_token=AAIOWJ6H4N6EWB34PANRHU3QMOZ5FA5CNFSM4I4N6WG2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCGRNWNY#pullrequestreview-295885623",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>