<blockquote>
<p>This doesn't make any sense, the point of including headers is so that definitions are available to compilers for checking and optimisations. By making them opaque pointers that is defeated.</p>
</blockquote>
<p>I disagree. If items inside <code>struct GeanyBuildCommand</code> are private and shall only be used inside <code>build.c</code> then it is practicable to use a forward declaration and hide the struct items. No code outside <code>build.c</code> can then use the struct in a wrong way. Of course this requires functions to access/use all aspects of <code>struct GeanyBuildCommand</code>. As the <code>struct GeanyFiletypePrivate</code> only uses pointers to <code>struct GeanyBuildCommand</code> the compiler has all information it needs and can still do type checks etc. (it is still a <code>struct GeanyBuildCommand *</code> not a <code>void *</code>). If something was missing then there would be a compiler error. But I would prefer a forward declaration with typedef.</p>
<p>As long as the items of <code>struct GeanyBuildCommand</code> shall only be used in <code>build.c</code> and if it shall stay like that in the future then I actually consider this good style.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2299?email_source=notifications&email_token=AAIOWJ6EOHNDDV4SATGEZDTQJSRNNA5CNFSM4IWNUYZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WXYBI#issuecomment-531463173">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJYTN2EQNBZLCHKCZYLQJSRNNANCNFSM4IWNUYZA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ5LVPHDKSR7QVNYO63QJSRNNA5CNFSM4IWNUYZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WXYBI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2299?email_source=notifications\u0026email_token=AAIOWJ6EOHNDDV4SATGEZDTQJSRNNA5CNFSM4IWNUYZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WXYBI#issuecomment-531463173",
"url": "https://github.com/geany/geany/pull/2299?email_source=notifications\u0026email_token=AAIOWJ6EOHNDDV4SATGEZDTQJSRNNA5CNFSM4IWNUYZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WXYBI#issuecomment-531463173",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>