<blockquote>
<p>the opposite since it forces you to do forward declaration</p>
</blockquote>
<p>How is that a negative vs including an entire header that is not needed?</p>
<blockquote>
<p>if the file uses a symbol defined in a header, it should include it. Manually introducing forward declarations should IMO be left to breaking circular dependencies alone.</p>
</blockquote>
<p>The point of including headers explicitly per-file is to reduce dependencies on source files. Otherwise we would have geany.h include all headers itself.</p>
<p>We already use forward struct declarations in many headers, most of them are not private structs:</p>
<pre><code>$ grep -E 'struct \w+;' src/*.h
src/editor.h:37:struct GeanyDocument;
src/filetypes.h:38:struct GeanyDocument;
src/geanyentryaction.h:42:struct _GeanyEntryActionPrivate;
src/geanymenubuttonaction.h:42:struct _GeanyMenubuttonActionPrivate;
src/keyfile.h:36:struct StashGroup;
src/pluginutils.h:34:struct GeanyPlugin;
src/pluginutils.h:35:struct GeanyDocument;
src/search.h:87:struct GeanyDocument; /* document.h includes this header */
src/search.h:88:struct _ScintillaObject;
src/search.h:89:struct Sci_TextToFind;
src/templates.h:57:struct filetype;
</code></pre>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2299?email_source=notifications&email_token=AAIOWJ2XCKIB2VFPEWYGQK3QJSYBVA5CNFSM4IWNUYZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WYTOQ#issuecomment-531466682">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ22MUTV633AEHHW5ATQJSYBVANCNFSM4IWNUYZA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ6GYYJDWAUU2CH6ZLDQJSYBVA5CNFSM4IWNUYZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WYTOQ.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2299?email_source=notifications\u0026email_token=AAIOWJ2XCKIB2VFPEWYGQK3QJSYBVA5CNFSM4IWNUYZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WYTOQ#issuecomment-531466682",
"url": "https://github.com/geany/geany/pull/2299?email_source=notifications\u0026email_token=AAIOWJ2XCKIB2VFPEWYGQK3QJSYBVA5CNFSM4IWNUYZKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6WYTOQ#issuecomment-531466682",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>