<p>This issue is to continue discussion in the comments of <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="453812109" data-permission-text="Issue title is private" data-url="https://github.com/geany/geany/issues/2178" data-hovercard-type="pull_request" data-hovercard-url="/geany/geany/pull/2178/hovercard" href="https://github.com/geany/geany/pull/2178">#2178</a> and <a class="issue-link js-issue-link" data-error-text="Failed to load issue title" data-id="484090911" data-permission-text="Issue title is private" data-url="https://github.com/geany/geany/issues/2270" data-hovercard-type="pull_request" data-hovercard-url="/geany/geany/pull/2270/hovercard" href="https://github.com/geany/geany/pull/2270">#2270</a> regarding the conventions/etiquette of merging a PR, especially one's own.</p>
<p>I suggest we categorize PRs (either using Github labels or own judgment) into the following types which probably will have different "rules" for merging:</p>
<ul>
<li>Obvious bug fix in the code or docs.</li>
<li>Code refactoring/cleanup or larger restructuring/rewording the docs.</li>
<li>Changes to the public plugin API</li>
<li>Small UI change or changing default/original behaviour of something</li>
<li>Large UI change</li>
<li>Larger more structural changes to the code</li>
</ul>
<p>Feel free to edit the description and re-word those or add others which are surely missing.</p>
<p>The criteria for a PR being mergeable might include such this as:</p>
<ul>
<li>None</li>
<li>Waiting at least N days to see if anyone cares/objects.</li>
<li>At least N people must approve the PR explicitly using Github "review" stuff.</li>
<li>At least N people must have done a proper code review.</li>
<li>At least N people must have actually tested it.</li>
<li>It must be tested on X platforms.</li>
</ul>
<p>Again, feel free to edit/add to this list.</p>
<p>I guess with the above lists, it's just a matter of attaching the criteria to each type of PR, and then codifying that somewhere like HACKING, the wiki, a new CONTRIBUTING file, or wherever. One way to do this association might be to do some simple polls of the contributors.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/issues/2283?email_source=notifications&email_token=AAIOWJ3W6HDTSI5GYAOXPF3QHG4TLA5CNFSM4ISSB6BKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIR4OBA">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJYMIIK7RX2QDXXP4VTQHG4TLANCNFSM4ISSB6BA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ3XZWVUIW45T7PBVE3QHG4TLA5CNFSM4ISSB6BKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIR4OBA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/issues/2283?email_source=notifications\u0026email_token=AAIOWJ3W6HDTSI5GYAOXPF3QHG4TLA5CNFSM4ISSB6BKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIR4OBA",
"url": "https://github.com/geany/geany/issues/2283?email_source=notifications\u0026email_token=AAIOWJ3W6HDTSI5GYAOXPF3QHG4TLA5CNFSM4ISSB6BKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HIR4OBA",
"name": "View Issue"
},
"description": "View this Issue on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>