<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=811085" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/elextr">@elextr</a><br>
I'm going to merge this soon as 2 developers agree with the change and I have tested all changed code paths. I don't think we should require pulls to be tested by a reviewer, that will inevitably cause good work to stay in PR purgatory instead of being merged. Also the easiest way for most people to test changes is when they're in master, and this also means the changes get real-world testing when the user is actually working on real code.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2178?email_source=notifications&email_token=AAIOWJ5RIETMRUFX2WBTOTTQHFB3NA5CNFSM4HWHUMYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5SDRAY#issuecomment-526661763">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ2HWNPVC2TEBZG2BR3QHFB3NANCNFSM4HWHUMYA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ4KOD2FGGFCYYNYKNLQHFB3NA5CNFSM4HWHUMYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5SDRAY.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2178?email_source=notifications\u0026email_token=AAIOWJ5RIETMRUFX2WBTOTTQHFB3NA5CNFSM4HWHUMYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5SDRAY#issuecomment-526661763",
"url": "https://github.com/geany/geany/pull/2178?email_source=notifications\u0026email_token=AAIOWJ5RIETMRUFX2WBTOTTQHFB3NA5CNFSM4HWHUMYKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5SDRAY#issuecomment-526661763",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>