<p><b>@LarsGit223</b> requested changes on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/897#discussion_r318750275">lineoperations/src/lo_prefs.h</a>:</p>
<pre style='color:#555'>> + *      51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+*/
+
+#ifndef LO_PREFS_H
+#define LO_PREFS_H
+
+#include <geanyplugin.h>
+#include "lo_prefs.h"
+
+
+typedef struct
+{
+       /* general settings */
+       gchar *config_file;
+       gboolean use_collation_compare;
+} AddonsInfo;
</pre>
<p>Is this intentionally named <code>AddonsInfo</code> or a copy&paste issue?</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/897#discussion_r318750384">lineoperations/src/lo_prefs.h</a>:</p>
<pre style='color:#555'>> +#ifndef LO_PREFS_H
+#define LO_PREFS_H
+
+#include <geanyplugin.h>
+#include "lo_prefs.h"
+
+
+typedef struct
+{
+       /* general settings */
+       gchar *config_file;
+       gboolean use_collation_compare;
+} AddonsInfo;
+
+
+extern AddonsInfo *lo_info;
</pre>
<p>Same question here.</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/897#discussion_r318751765">lineoperations/README</a>:</p>
<pre style='color:#555'>> +appear ("Tools" > "Line Operations"). Click on each menu item to apply
+the operation on whole file, or selection. See descriptions below to
+see operations for each menu item.
+
+Preferences
+-----------
+
+To enable preferences ("Tools" > "Plugin Manager"), check the checkbox to
+enable Line Operations, and with the item highlighted click "Preferences"
+on bottom of the "Plugin Manager" frame.
+
+**Use collation based string compare** - When this option is enabled it will
+compare strings using linguistically correct rules for the current locale
+(g_utf8_collate).
+
+When it is disabled it will compare strings based off numerical value of the
</pre>
<p>Should it be <em>"based off"</em> or <em>"based on"</em>?</p>

<hr>

<p>In <a href="https://github.com/geany/geany-plugins/pull/897#discussion_r318753477">lineoperations/src/lo_fns.c</a>:</p>
<pre style='color:#555'>> -#include "linefunctions.h"
+#include "lo_fns.h"
+#include "lo_prefs.h"
+
+
+/* Get sort function based on user preferences */
+lo_strcmpfns
+getcmpfns(void)
+{
+       if(lo_info->use_collation_compare)
+       {
+               return g_utf8_collate;
+       }
+       else
+       {
+               return strcmp;
</pre>
<p>Maybe you like to prefer <code>g_strcmp0</code> from the glib here? The same as <code>strcmp</code> just a bit safer but from glib.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany-plugins/pull/897?email_source=notifications&email_token=AAIOWJ5TGQXOEOBDRQSWUTLQG3GYZA5CNFSM4IK5FTCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDAHE4Y#pullrequestreview-281047667">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ2WSNFKCWLXCL35BU3QG3GYZANCNFSM4IK5FTCA">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ4LX6ZAELLOBPFYCHTQG3GYZA5CNFSM4IK5FTCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDAHE4Y.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany-plugins/pull/897?email_source=notifications\u0026email_token=AAIOWJ5TGQXOEOBDRQSWUTLQG3GYZA5CNFSM4IK5FTCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDAHE4Y#pullrequestreview-281047667",
"url": "https://github.com/geany/geany-plugins/pull/897?email_source=notifications\u0026email_token=AAIOWJ5TGQXOEOBDRQSWUTLQG3GYZA5CNFSM4IK5FTCKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDAHE4Y#pullrequestreview-281047667",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>