<p><a class="user-mention" data-hovercard-type="user" data-hovercard-url="/hovercards?user_id=811085" data-octo-click="hovercard-link-click" data-octo-dimensions="link_type:self" href="https://github.com/elextr">@elextr</a>:</p>
<blockquote>
<p>these seem to be just waste of time noise</p>
</blockquote>
<p>Please avoid this kind of language. It sounds like you are annoyed. Obviously I do not think it is a waste of time or I would not have submitted it. I often don't submit changes I have done that aren't of clear benefit.</p>
<p>I have removed the second commit (and updated the PR description), to avoid making a subtle argument for it. Regarding the first:</p>
<p>Smaller functions are easier to understand, and build_load_menu is complicated.<br>
build_load_menu has 2 top-level scope variables that aren't used by load_old_menu.<br>
load_old_menu has 4 top-level scope variables that aren't used by build_load_menu.<br>
Each function reads different groups of data.</p>
<p>This should tell you that the code doesn't belong in one function.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2272?email_source=notifications&email_token=AAIOWJ2GMNPFTO4QVNJOBQ3QGD2ARA5CNFSM4IPBGRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5B4CUI#issuecomment-524534097">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ7SAIZJK2QWKH3KPPLQGD2ARANCNFSM4IPBGRBQ">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ6LQUWKYB74OGI5JCTQGD2ARA5CNFSM4IPBGRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5B4CUI.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2272?email_source=notifications\u0026email_token=AAIOWJ2GMNPFTO4QVNJOBQ3QGD2ARA5CNFSM4IPBGRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5B4CUI#issuecomment-524534097",
"url": "https://github.com/geany/geany/pull/2272?email_source=notifications\u0026email_token=AAIOWJ2GMNPFTO4QVNJOBQ3QGD2ARA5CNFSM4IPBGRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5B4CUI#issuecomment-524534097",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>