<p><b>@ntrel</b> commented on this pull request.</p>

<hr>

<p>In <a href="https://github.com/geany/geany/pull/2270#discussion_r317350085">HACKING</a>:</p>
<pre style='color:#555'>> @@ -219,6 +219,10 @@ Coding
   ``gint``, use a ``gchar`` for individual (ASCII/UTF-8) string
   characters rather than ``gint``, and use a ``guint`` for integers
   which cannot be negative rather than ``gint``.
+* Avoid using untyped pointers (e.g. gpointer) where practical.
+* Prefer loops to calling *_foreach() with a non-NULL untyped 
+  ``user_data`` pointer parameter, unless external iteration is not 
+  supported (e.g. for tree structures).
</pre>
<p>I've changed it to just "calling <code>some_type_foreach()</code> with a <code>user_data</code> argument". I think the last part implies that a NULL argument is OK. I agree that loops are generally better than *_foreach functions, but there are some cases where they're fine.</p>

<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br />You are receiving this because you are subscribed to this thread.<br />Reply to this email directly, <a href="https://github.com/geany/geany/pull/2270?email_source=notifications&email_token=AAIOWJYE3SA5SI3K2ZOQRJTQGDVR5A5CNFSM4IOW2V4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCSX3LA#discussion_r317350085">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/AAIOWJ5LU3OE5SR6NKBAH4LQGDVR5ANCNFSM4IOW2V4A">mute the thread</a>.<img src="https://github.com/notifications/beacon/AAIOWJ5JGWI4IHEICM5XDBLQGDVR5A5CNFSM4IOW2V4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCSX3LA.gif" height="1" width="1" alt="" /></p>
<script type="application/ld+json">[
{
"@context": "http://schema.org",
"@type": "EmailMessage",
"potentialAction": {
"@type": "ViewAction",
"target": "https://github.com/geany/geany/pull/2270?email_source=notifications\u0026email_token=AAIOWJYE3SA5SI3K2ZOQRJTQGDVR5A5CNFSM4IOW2V4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCSX3LA#discussion_r317350085",
"url": "https://github.com/geany/geany/pull/2270?email_source=notifications\u0026email_token=AAIOWJYE3SA5SI3K2ZOQRJTQGDVR5A5CNFSM4IOW2V4KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCSX3LA#discussion_r317350085",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
"@type": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>